Re: [PATCH] drm: Suppress user controlled spam for invalid drm_wait_vblank_ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Daniel Vetter (2018-09-04 14:08:12)
> On Tue, Sep 04, 2018 at 12:57:19PM +0100, Chris Wilson wrote:
> > The ioctl arguments are under control of the user and as such we should
> > resist any temptation to flood the kernel logs with their errors.
> > Relegate the DRM_ERROR to a DRM_DEBUG so the user has to opt into
> > hearing of their own mistakes. (One day we will have a small ringbuffer
> > attached to the task, so that the concerned process can inspect its own
> > debug info for EINVAL without them being hitting syslog at all.)
> > 
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> 
> igt for this would be lovely. Either way Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

Pushed and negative igt sent.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux