On Fri, Feb 03, 2012 at 10:04:27AM +0000, Dave Airlie wrote: > On Wed, Feb 1, 2012 at 10:38 AM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > > The fb helper uses fixed size arrays for the associated crtcs. > > This is an unnecessary limitation, so instead use a list to > > store the crtcs and allocate them dynamically. > > I need more reasons on why this is a unnecessary limitation, for what? > > Its a lot less cache friendly to use a linked list here for not much gain, How often do you change modes? This code is run when the user changes virtual terminals, which is not very performance critical. > > do you want to attach/detach crtcs from fb at runtime? I am working on a mid layer to connect simple framebuffer devices to kms and it would be convenient to just add a crtc to a drm device once it appears. This works fine for connectors and encoders, why not also for crtcs? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
