Re: [PATCH 20/20] drm: do not set fb_info->pixmap fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed,  1 Feb 2012 11:38:38 +0100, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> The drm drivers set the fb_info->pixmap fields without setting
> fb_info->pixmap.addr. If this is not set the fb core will overwrite
> these all fb_info->pixmap fields anyway, so there is not much point
> in setting them in the first place.

Might be worth replacing those blocks with a comment:
  /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux