On Jan 31, 2012, at 8:59 AM, Eric Anholt wrote: > On Mon, 30 Jan 2012 15:25:20 -0800, Jeremy Huddleston <jeremyhu@xxxxxxxxxxxxxxx> wrote: >> This fixes a failure in 'make check' found by the tinderbox when trying to >> build this code on Linux/ppc. This code is only designed to run on >> Intel platforms, so don't even bother building it if we're not in that set. > > Looks reasonable to me, except it should probably be checking $target_os > (cross-compile target) rather than $host_os (cross compile build host). I think you are misunderstanding the variables (or perhaps you are following Mozilla's usage of the variables, which is wrong but internally consistent). CBUILD - The platform of the machine being built on. CHOST - The platform that the delivered product will run on. CTARGET- The platform that the delivered product will generate code for. CTARGET is only really relevant for toolchain packages. eg. I want to build a gcc that builds mips code and runs on my intel box: CTARGET=mips-* CHOST=i686-* If I want to do the building of that compiler on my ppc box: CBUILD=powerpc-* CTARGET=mips-* CHOST=i686-* --Jeremy _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
