On Friday, July 27, 2018 09:16:42 AM Geert Uytterhoeven wrote: > Hi Randy, > > On Fri, Jul 27, 2018 at 2:00 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > > > Fix build warning when built as a loadable module. > > amifb_setup() and amifb_setup_mcap() are only needed when the driver > > is builtin. > > This matches how the functions are called (using #ifndef MODULE). > > > > ../drivers/video/fbdev/amifb.c:2344:19: warning: 'amifb_setup' defined but not used [-Wunused-function] > > static int __init amifb_setup(char *options) > > > > ../drivers/video/fbdev/amifb.c:2307:20: warning: 'amifb_setup_mcap' defined but not used [-Wunused-function] > > static void __init amifb_setup_mcap(char *spec) > > Thanks for your patch! > > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
