On 30/07/18 02:04, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Monday, 18 June 2018 16:22:36 EEST Tomi Valkeinen wrote: >> Add DT bindings for Texas Instruments AM65x SoC Display Subsystem. The >> DSS7 on AM65x SoC has two video ports (DPI and OLDI) and two video >> pipelines. >> >> Signed-off-by: Jyri Sarha <jsarha@xxxxxx> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> >> Cc: devicetree@xxxxxxxxxxxxxxx >> --- >> .../bindings/display/ti/ti,am6-dss.txt | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/ti/ti,am6-dss.txt >> >> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am6-dss.txt >> b/Documentation/devicetree/bindings/display/ti/ti,am6-dss.txt new file mode >> 100644 >> index 000000000000..3466f095fb84 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/ti/ti,am6-dss.txt >> @@ -0,0 +1,16 @@ >> +Texas Instruments AM65x Display Subsystem >> +========================================== >> + >> +Required properties: >> +- compatible: "ti,am65x-dss", "ti,am6-dss" >> +- reg: address and length of the register spaces for DSS submodules >> +- reg-names: "common", "vidl1", "vid", "ovr1", "ovr2", "vp1", "vp2" >> +- clocks: phandle to fclk, vp1, and vp2 clocks >> +- clock-names: "fck", "vp1", "vp2" >> +- interrupts: phandle to the DISPC interrupt >> +- syscon: phandle to syscon device handling OLDI_PWRDN_TX (partition 1 of >> + AM654 CTRL MMR0) >> + >> +The DSS outputs are described using the device graphs as documented in >> +Documentation/devicetree/bindings/graph.txt. AM6 DSS has a DPI output as >> port 0 >> +and an OLDI output as port 1. > > Without documentation for the AM65x it's hard to review these DT bindings. > However, my comment regarding the registers of the k2g-dss bindings applies > here too. Sorry that I didn't provide the link. I guess it's not easily found from ti.com at the moment: http://www.ti.com/lit/ug/spruid7/spruid7.pdf -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
