Re: [PATCH 04/10] drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of copying the logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alexandru,

On Fri, 20 Jul 2018 22:15:03 +0100
Alexandru Gheorghe <alexandru-cosmin.gheorghe@xxxxxxx> wrote:

Please add a commit message here (even if it's just repeating what the
subject says).

> Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@xxxxxxx>

With this addressed:

Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>

> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index 04440064b9b7..9330a076e15a 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -942,10 +942,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p)
>  				"Failed to allocate initial plane state\n");
>  			return;
>  		}
> -
> -		p->state = &state->base;
> -		p->state->alpha = DRM_BLEND_ALPHA_OPAQUE;
> -		p->state->plane = p;
> +		__drm_atomic_helper_plane_reset(p, &state->base);
>  	}
>  }
>  

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux