Re: [PATCH v3 0/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 19-07-18 12:15, Thomas Zimmermann wrote:
Hi,

this is version 3 of the WARN_CONSOLE_UNLOCKED patch set. The
macro prints a warning if the console's critical sections are
entered without holding the console lock. This patch set allows
to disable the warnings while debugging the console.

In the original approach, WARN_CONSOLE_UNLOCKED was disabled by
setting ignore_console_lock_warning of type bool. As suggested by
Petr Mladek, the new implementation is based on atomic_t and allows
multiple threads to manipulate the warning state concurrently.

With version 3, the patch set now includes the patch for introducing
ignore_console_lock_warning. This patch superseds all previous patches
of the same purpose.

Best regards
Thomas

v3:
	- implement ignore_console_lock_warning with atomic_t
v2:
	- restore ignore_console_lock_warning if lock_fb_info() fails

Thomas Zimmermann (2):
   console: Replace #if 0 with atomic var 'ignore_console_lock_warning'
   fbdev/core: Disable console-lock warnings when fb.lockless_register_fb
     is set

I just saw this version after my comment on v2 that the race there
was not really a problem.

This version is even better though :)    :

Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux