On Fri, 13 Jul 2018 10:06:01 +0200,
Jim Qu wrote:
>
> Signed-off-by: Jim Qu <Jim.Qu@xxxxxxx>
More explanations please. e.g. why is this needed?
The code change itself looks good, but ...
> @@ -31,7 +31,7 @@
> * CHANGES:
> *
> * 2004.12.01 Major rewrite by tiwai, merged the work of pshou
> - *
> + *
> */
>
> #include <linux/delay.h>
> @@ -390,8 +390,8 @@ static char *driver_short_names[] = {
> [AZX_DRIVER_SIS] = "HDA SIS966",
> [AZX_DRIVER_ULI] = "HDA ULI M5461",
> [AZX_DRIVER_NVIDIA] = "HDA NVidia",
> - [AZX_DRIVER_TERA] = "HDA Teradici",
> - [AZX_DRIVER_CTX] = "HDA Creative",
> + [AZX_DRIVER_TERA] = "HDA Teradici",
> + [AZX_DRIVER_CTX] = "HDA Creative",
> [AZX_DRIVER_CTHDA] = "HDA Creative",
> [AZX_DRIVER_CMEDIA] = "HDA C-Media",
> [AZX_DRIVER_GENERIC] = "HD-Audio Generic",
These two hunks are utterly irrelevant with the fix. Please drop
them.
thanks,
Takashi
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
