On Thu 2018-07-12 09:30:49, Steven Rostedt wrote: > On Thu, 12 Jul 2018 09:29:38 -0400 > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > From: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> > > > > There's been discussion on the fb list about the addition of > > WARN_CONSOLE_UNLOCKED() inside the fb code. The complaint is that when > > the fb module is loaded with lockless_register_fb the console lock is > > not taken for debugging reasons. With the addition of > > WARN_CONSOLE_UNLOCK() within the fb code, this causes the console to > > fill up with warnings when trying to debug the fb driver. > > > > There's also a #if 1 that enables the warning which was added before > > git history, and we look down on constant #if's in the kernel nowadays > > anyway. > > > > Remove the #if 1 and add a ignore_console_lock_warning boolean that can > > be set by drivers to ignore the warning in order to do debugging. > > > > Link: http://lkml.kernel.org/r/717e6337-e7a6-7a92-1c1b-8929a25696b5@xxxxxxx > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > Acked-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> > > Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> > > Petr, > > If you want this to go by way of fbdev tree, then can you Ack it? Sure. Acked-by: Petr Mladek <pmladek@xxxxxxxx> I assume that it will go via fbdev tree with the other changes unless I hear otherwise. Best Regards, Petr _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
