On Fri, Jul 06, 2018 at 02:45:53PM +0200, Arnd Bergmann wrote: > Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module results in > a link error, as we try to access a symbol from the sun8i_tcon_top.ko module: > > ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun8i-drm-hdmi.ko] undefined! > ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun4i-drm.ko] undefined! > > This solves the problem by making DRM_SUN8I_MIXER a 'bool' symbol, building > the sun8i_tcon_top module the same way as the core sun4i-drm module whenever > DRM_SUN8I_MIXER is enabled, or not building it at all otherwise. > > Alternatively, we could always build sun8i_tcon_top.ko along with sun4-drm.ko > and detach it from the mixer module, I could not tell which way is more > appropriate here. If that's easily doable, then yeah, that would be the preferred option I guess. Jernej? Chen-Yu? Any opinion on this? Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
