Re: [PATCH 0/4] drm/i915/intel_dsi: Read back and use pclk set by the GOP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 29 Jun 2018, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Hi,
>
> On 19-06-18 22:18, Hans de Goede wrote:
>> Hi All,
>> 
>> This patch-set is the result of the work I've been doing recently to
>> give people a smooth "flickerfree" boot experience where the display
>> keeps displaying the logo put there by the firmware until it smoothly
>> fades into the Linux GUI (e.g. gdm).
>> 
>> While testing this on some BYT/CHT devices I noticed the screen going
>> black for 1 second or so, because the first modeset was not a fast
>> modeset despite passing i915.fastboot=1 on the kernel commandline.
>> 
>> This is caused by the GOP and the i915 code differing in what they
>> think the DSI pclk should be. This patch-set fixes this by reading
>> back the pclk set by the GOP and if it is reasonably close to the
>> clk calculated by the i915 code, using the GOP set pclk.
>
> Ping? A review of this series would be appreciated.

Sorry, swamped, and I was hoping Ville would chime in. ;)

The first two patches are trivial, ack. But I'd really like to know what
the GOP is doing, and why we're different. Not sure if that's possible.

I'm afraid after much bikeshedding there were some file and function
renames, and no matter what this series needs a rebase. See [1]. Sorry
about the extra effort this causes; I truly appreciate your efforts with
the DSI code, and I regret I haven't given this series the love it
needs.

BR,
Jani.

[1] https://patchwork.freedesktop.org/series/45984/


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux