Hi Rob Herring,
Thanks for your review.
在 2018/7/4 2:25, Rob Herring 写道:
On Tue, Jun 26, 2018 at 03:15:39PM +0800, Sandy Huang wrote:
This path add support rv1108 and px30 rgb output interface driver.
Bindings are for h/w, not drivers.
I will update at next version as following:
This patch add support rv1108 and px30 rgb output interface
Signed-off-by: Sandy Huang <hjc@xxxxxxxxxxxxxx>
Link: https://patchwork.freedesktop.org/patch/msgid/1509522765-118759-1-git-send-email-hjc@xxxxxxxxxxxxxx
---
Changes in v4: Add support px30
Changes in v3: None
Changes in v2: None
.../bindings/display/rockchip/rockchip-rgb.txt | 73 ++++++++++++++++++++++
1 file changed, 73 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt
new file mode 100644
index 0000000..077b9ad
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt
@@ -0,0 +1,73 @@
+Rockchip RV1108 RGB interface
+================================
+
+Required properties:
+- compatible: matching the soc type:
+ - "rockchip,px30-rgb";
+ - "rockchip,rv1108-rgb";
This doesn't look right? What (and how) is getting programmed here
because you don't have any register interface.
This is register for DRM encoder and connecter or bridge for some RGB
convert chips driver.
so far we don't have any register for rgb interface, but it's most
probable need to config some register for rgb interface in feauture for
rockchip platform.
+
+Optional properties:
+- pinctrl-names: should be a "lcdc" entry or a "default" entry.
+- pinctrl-0: pin control group to be used for this interface.
+
+The rgb has two video ports described by:
+ Documentation/devicetree/bindings/media/video-interfaces.txt
+Their connections are modeled using the OF graph bindings specified in
+ Documentation/devicetree/bindings/graph.txt.
+
+- video port 0 for the VOP input, the remote endpoint maybe vopb/vopl/vop
So there is a mux for these inputs and they are switched with pinctrl?
connetced can connect to vopb/vopl/vop which is same with other
connenter like edp/dsi/lvds, there is a sample for edp
at:Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
Just put the pinctrl nodes of the sources and enable whichever one is
active.
Do you think i need add pinctrl nodes here? Or am I wrong?
Rob
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
