On Tue, 26 Jun 2018 15:55:34 +0200 Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Replace comments about places where the console lock should be held with > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. Why replace the comments? I prefer them, even with the WARN. The reason is, when using functions, I don't tend to look inside the function I'm about to use, but instead, I expect the comment above the function to have basic information I need to use it. Especially what locks are expected to be held. Please keep the comments in place, but the WARNs are fine. They are not a replacement for the comments. Nack on removing comments. -- Steve _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
