Am 21.06.2018 16:53, schrieb Christian König:
Am 21.06.2018 um 15:21 schrieb Thomas Zimmermann:
TTM buffer objects provide ttm_bo_reference() and ttm_bo_unref() for
managing reference counters. This patch set introduces ttm_bo_get()
and ttm_ot_put(), which follow Linux kernel conventions.
^^^^^^^^^^^^^^
I hope this typo is only in explanation text...;-)
Greetings,
Dieter
A call to ttm_bo_unref() clears the supplied pointer to NULL. This is
unnecessary in most cases and occationally callers have to work around
this behaviour. ttm_bo_put() only releases the reference, but keeps
the pointer's value.
This patch set introduces ttm_bo_get() and ttm_bo_put(), and converts
TTM to the new functions. The old functions remain in place until all
callers have been converted.
Thanks, series is Reviewed-by: Christian König
<christian.koenig@xxxxxxx> and I'm going to pick it up for our
internal TTM branch.
It is appreciated that you do this only one driver/component at a time
and not in a massive change.
Are you planning to stick with applying that to the individual drivers
using it?
Thanks,
Christian.
Thomas Zimmermann (3):
drm/ttm: Introduce ttm_bo_get() and ttm_bo_put() for ref counting
drm/ttm: Replace ttm_bo_reference() with ttm_bo_get()
drm/ttm: Replace ttm_bo_unref() with ttm_bo_put()
drivers/gpu/drm/ttm/ttm_bo.c | 10 ++++++++--
drivers/gpu/drm/ttm/ttm_bo_util.c | 11 ++++++-----
drivers/gpu/drm/ttm/ttm_bo_vm.c | 18 ++++++++++--------
include/drm/ttm/ttm_bo_api.h | 25 ++++++++++++++++++++++++-
4 files changed, 48 insertions(+), 16 deletions(-)
--
2.14.4
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
