On Sat, 14 Jan 2012, Jesper Juhl wrote: > In psb_intel_lvds_init(), if we fail to allocate memory for > 'psb_intel_connector' we free the memory we previously allocated for > 'psb_intel_encoder', but we then proceed to use that free'd pointer > when we do 'psb_intel_encoder->dev_priv = lvds_priv;'. > > I believe the proper way to handle this is to simply return after the > allocation for 'psb_intel_connector' has failed. That is what this > patch does. > Ok, so I just noticed that we may also leak 'psb_intel_encoder' if we 'goto failed_connector;'. Might as well fix that as well in the same patch. So please just ignore this one. I'll submit a new one in a little while that handles both leaks. -- Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
