On Tue, Jun 19, 2018 at 1:56 PM, Keith Packard <keithp@xxxxxxxxxx> wrote:
Jason Ekstrand <jason@xxxxxxxxxxxxxx> writes:
> 1) We weren't setting planeReorderPossible at all and we were using 0
> instead of VK_FALSE (they're the same but we should use the enum) for
> persistentContent
> 2) We weren't advertising disconnected connectors via
> GetPhysicalDeviceDisplayProperties but were returning them from And that seems to at least make CTS happy. I've merged your fixes into
> GetPhysicalDeviceDisplayPlaneProperties.
> 3) We weren't setting result if the condition variable failed to
> initialize (thanks GCC!)
>
> There is one outstanding issue that the CTS is complaining about, namely
> that you can't create modes. It tests that mode creation fails for a mode
> with a zero width, height, or refresh rate and that's all fine. It then
> tries to re-create one of the modes that we've returned to it in
> GetDisplayModeProperties and assumes that it will work. We should probably
> at least make sure that works by walking the list and looking for a mode
> that matches the requested one and returning it. I don't think anything
> actually requires us to return a unique pointer so it can be a search
> instead of a create.
the first patch, added support for vkCreateDisplayModeKHR, rebased to
master and pushed the results to my repository.
It looks like we're done here but I'll wait until I hear from you before
pushing to master in case you've got additional concerns.
Looks good. Passes the CTS. Push it!
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
