linux-4.18-rc1/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c:207: broken nested if ?

[David Binderman <dcb314@xxxxxxxxxxx>]

Hello there,

[linux-4.18-rc1/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c:208]: (warning) Identical inner 'if' condition is always true.

Source code is

        if (set_clocks && adev->pm.dpm_enabled) {
                if (adev->pm.dpm_enabled)
                        amdgpu_dpm_enable_uvd(adev, true);
                else
                        amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VCN,
                                                               AMD_PG_STATE_UNGATE);

So second function call never happens. Suggest code rework.

Regards

David Binderman
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel