Re: [PATCH] drm: Constify mode argument to connector .mode_valid() helper operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 11, 2018 at 07:51:01PM +0300, Ville Syrjälä wrote:
> On Thu, Jun 07, 2018 at 03:13:23PM +0300, Laurent Pinchart wrote:
> > Hi Ville,
> > 
> > On Thursday, 7 June 2018 15:03:12 EEST Ville Syrjälä wrote:
> > > On Wed, Jun 06, 2018 at 12:08:12PM +0300, Laurent Pinchart wrote:
> > > > The drm_connector_helper_funcs .mode_valid() operation should not modify
> > > > the mode it receives in any way. To make this explicit, constify the
> > > > mode pointer as done for all other .mode_valid() operations, and update
> > > > all drivers accordingly.
> > > > 
> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > > 
> > > Didn't spot anything wrong. I think the omap case should be fine as
> > > well since the probe helper will populate the vrefresh for the mode
> > > eventually.
> > > 
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > 
> > The patch has lived in my public tree for a few days now and the kbuild bot 
> > hasn't complained (or rather it complained on the previous version that I 
> > hadn't posted to the list yet, and I've fixed the problems before posting this 
> > version). Given the risk of conflicts I'd rather get this merged sooner than 
> > later. Is that fine with you ?
> 
> Seems safe to me. So IMO just push if no one has complained.

Hm I haven't seen this land yet. Since you (= Laurent) have commit rights,
I assume it'll hapen without my involvement ...
-Daniel

> 
> > 
> > > > ---
> > > > 
> > > > This patch touches lots of drivers, so checkpatch.pl created a huge CC
> > > > list that would likely be too large for the mailing list. As changes to
> > > > most files just boil down to adding a const keyword, I've decided to only
> > > > CC the DRM misc maintainers, as well as Tomi for omapdrm as the change to
> > > > that driver is slightly more complex.
> > > > 
> > > >  drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c           |  8 ++++----
> > > >  drivers/gpu/drm/amd/amdgpu/atombios_dp.c                 |  2 +-
> > > >  drivers/gpu/drm/amd/amdgpu/atombios_dp.h                 |  2 +-
> > > >  drivers/gpu/drm/amd/amdgpu/dce_virtual.c                 |  2 +-
> > > >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c        |  2 +-
> > > >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h        |  2 +-
> > > >  drivers/gpu/drm/ast/ast_mode.c                           |  2 +-
> > > >  drivers/gpu/drm/bochs/bochs_kms.c                        |  2 +-
> > > >  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c             |  4 ++--
> > > >  drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c |  2 +-
> > > >  drivers/gpu/drm/bridge/sii902x.c                         |  2 +-
> > > >  drivers/gpu/drm/bridge/tc358767.c                        |  2 +-
> > > >  drivers/gpu/drm/exynos/exynos_hdmi.c                     |  2 +-
> > > >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c                |  2 +-
> > > >  drivers/gpu/drm/gma500/cdv_intel_crt.c                   |  2 +-
> > > >  drivers/gpu/drm/gma500/cdv_intel_dp.c                    |  2 +-
> > > >  drivers/gpu/drm/gma500/cdv_intel_hdmi.c                  |  2 +-
> > > >  drivers/gpu/drm/gma500/cdv_intel_lvds.c                  |  2 +-
> > > >  drivers/gpu/drm/gma500/mdfld_dsi_output.c                |  2 +-
> > > >  drivers/gpu/drm/gma500/oaktrail_hdmi.c                   |  2 +-
> > > >  drivers/gpu/drm/gma500/psb_intel_drv.h                   |  2 +-
> > > >  drivers/gpu/drm/gma500/psb_intel_lvds.c                  |  2 +-
> > > >  drivers/gpu/drm/gma500/psb_intel_sdvo.c                  |  2 +-
> > > >  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c         |  2 +-
> > > >  drivers/gpu/drm/i2c/ch7006_drv.c                         |  2 +-
> > > >  drivers/gpu/drm/i2c/sil164_drv.c                         |  2 +-
> > > >  drivers/gpu/drm/i2c/tda998x_drv.c                        |  2 +-
> > > >  drivers/gpu/drm/i915/dvo.h                               |  2 +-
> > > >  drivers/gpu/drm/i915/dvo_ch7017.c                        |  2 +-
> > > >  drivers/gpu/drm/i915/dvo_ch7xxx.c                        |  2 +-
> > > >  drivers/gpu/drm/i915/dvo_ivch.c                          |  2 +-
> > > >  drivers/gpu/drm/i915/dvo_ns2501.c                        |  2 +-
> > > >  drivers/gpu/drm/i915/dvo_sil164.c                        |  2 +-
> > > >  drivers/gpu/drm/i915/dvo_tfp410.c                        |  2 +-
> > > >  drivers/gpu/drm/i915/intel_crt.c                         |  2 +-
> > > >  drivers/gpu/drm/i915/intel_dp.c                          |  2 +-
> > > >  drivers/gpu/drm/i915/intel_dp_mst.c                      |  2 +-
> > > >  drivers/gpu/drm/i915/intel_dsi.c                         |  2 +-
> > > >  drivers/gpu/drm/i915/intel_dvo.c                         |  2 +-
> > > >  drivers/gpu/drm/i915/intel_hdmi.c                        |  2 +-
> > > >  drivers/gpu/drm/i915/intel_lvds.c                        |  2 +-
> > > >  drivers/gpu/drm/i915/intel_sdvo.c                        |  2 +-
> > > >  drivers/gpu/drm/i915/intel_tv.c                          |  2 +-
> > > >  drivers/gpu/drm/imx/imx-tve.c                            |  2 +-
> > > >  drivers/gpu/drm/mediatek/mtk_hdmi.c                      |  2 +-
> > > >  drivers/gpu/drm/meson/meson_venc_cvbs.c                  |  2 +-
> > > >  drivers/gpu/drm/mgag200/mgag200_mode.c                   |  4 ++--
> > > >  drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c      |  2 +-
> > > >  drivers/gpu/drm/msm/dsi/dsi_manager.c                    |  2 +-
> > > >  drivers/gpu/drm/msm/edp/edp_connector.c                  |  2 +-
> > > >  drivers/gpu/drm/msm/hdmi/hdmi_connector.c                |  2 +-
> > > >  drivers/gpu/drm/nouveau/dispnv04/tvnv17.c                |  2 +-
> > > >  drivers/gpu/drm/nouveau/dispnv50/disp.c                  |  2 +-
> > > >  drivers/gpu/drm/nouveau/nouveau_connector.c              |  2 +-
> > > >  drivers/gpu/drm/omapdrm/omap_connector.c                 |  7 ++++---
> > > >  drivers/gpu/drm/qxl/qxl_display.c                        |  2 +-
> > > >  drivers/gpu/drm/radeon/atombios_dp.c                     |  2 +-
> > > >  drivers/gpu/drm/radeon/radeon_connectors.c               | 10 +++++-----
> > > >  drivers/gpu/drm/radeon/radeon_dp_mst.c                   |  2 +-
> > > >  drivers/gpu/drm/radeon/radeon_mode.h                     |  2 +-
> > > >  drivers/gpu/drm/rockchip/cdn-dp-core.c                   |  2 +-
> > > >  drivers/gpu/drm/rockchip/inno_hdmi.c                     |  2 +-
> > > >  drivers/gpu/drm/sti/sti_dvo.c                            |  2 +-
> > > >  drivers/gpu/drm/sti/sti_hda.c                            |  2 +-
> > > >  drivers/gpu/drm/sti/sti_hdmi.c                           |  2 +-
> > > >  drivers/gpu/drm/sun4i/sun4i_tv.c                         |  2 +-
> > > >  drivers/gpu/drm/tegra/dsi.c                              |  2 +-
> > > >  drivers/gpu/drm/tegra/hdmi.c                             |  2 +-
> > > >  drivers/gpu/drm/tegra/rgb.c                              |  2 +-
> > > >  drivers/gpu/drm/tegra/sor.c                              |  2 +-
> > > >  drivers/gpu/drm/tilcdc/tilcdc_crtc.c                     |  3 ++-
> > > >  drivers/gpu/drm/tilcdc/tilcdc_drv.h                      |  3 ++-
> > > >  drivers/gpu/drm/tilcdc/tilcdc_external.c                 |  2 +-
> > > >  drivers/gpu/drm/tilcdc/tilcdc_panel.c                    |  2 +-
> > > >  drivers/gpu/drm/tilcdc/tilcdc_tfp410.c                   |  2 +-
> > > >  drivers/gpu/drm/udl/udl_connector.c                      |  2 +-
> > > >  drivers/gpu/drm/virtio/virtgpu_display.c                 |  2 +-
> > > >  drivers/gpu/drm/zte/zx_hdmi.c                            |  2 +-
> > > >  drivers/gpu/drm/zte/zx_tvenc.c                           |  4 ++--
> > > >  drivers/gpu/drm/zte/zx_vga.c                             |  2 +-
> > > >  drivers/staging/vboxvideo/vbox_mode.c                    |  2 +-
> > > >  include/drm/drm_encoder_slave.h                          |  2 +-
> > > >  include/drm/drm_modeset_helper_vtables.h                 |  2 +-
> > > >  83 files changed, 98 insertions(+), 95 deletions(-)
> > 
> > [snip]
> > 
> > -- 
> > Regards,
> > 
> > Laurent Pinchart
> > 
> > 
> 
> -- 
> Ville Syrjälä
> Intel
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux