On 07/06/18 15:03, Ville Syrjälä wrote: > On Wed, Jun 06, 2018 at 12:08:12PM +0300, Laurent Pinchart wrote: >> The drm_connector_helper_funcs .mode_valid() operation should not modify >> the mode it receives in any way. To make this explicit, constify the >> mode pointer as done for all other .mode_valid() operations, and update >> all drivers accordingly. >> >> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Didn't spot anything wrong. I think the omap case should be fine as > well since the probe helper will populate the vrefresh for the mode > eventually. > > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Looks fine to me too, although in omap_connector the debug print at the end will print the original vrefresh, not the calculated one. I'm not sure which one it should print, though. Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
