On 23 May 2018 at 19:13, Russell King <rmk@xxxxxxxxxxxxxxx> wrote: > On Wed, May 23, 2018 at 10:48:15AM +0200, Daniel Vetter wrote: >> On Tue, May 22, 2018 at 09:27:07AM +0100, Russell King wrote: >> > On Tue, May 22, 2018 at 10:53:49AM +1000, Dave Airlie wrote: >> > > Sorry I missed this, just fell between the cracks, >> > > >> > > Any reason you can't/don't use git pull-request to generate pulls? we >> > > have some scripts that parse pulls for tracking now, but this pull >> > > didn't get into the system as it doesn't use the template. >> > >> > I've never used git pull-request, and it doesn't seem to be part of >> > the git installation I have: >> >> The command is called request-pull. Our scripting wraps it in >> pull-request, which I guess caused the confusion. > > [Adding Linus] > > Hmm, so where do people put the hand-written commentry in a git > request-pull formatted request that Linus likes to see when sending > such requests to Linus? > > I can understand other maintainers not caring about that, but whatever > solution I have to this must work for sending to Linus as well - the > format of my pull requests are based on an example format from Linus > in the early days of git before request-pull even existed. They also > satisfy Linus' other need which is that they need to be clearly > identifyable as truely being from the maintainer - I believe Linus > uses format and language in the request as part of that. > > The other thing I notice is that the request-pull format is very > impersonal, doesn't say what the summary of changes are (it probably > has no way to do so), and contains no gratitudes - its tone is very > much like an order than a request. Compare the one I sent in April > with this: If you look at any of the ones I send and Linus accepts they are all generated with the git script, I think Linus likes seeing things with the git script. I tend to just write a summary before the contents of the pull request that the script produces. Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
