Re: [PATCH 2/2] Use char * for struct drm_dp_aux_msg's buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 21 May 2018, Maya Rashish <coypu@xxxxxxx> wrote:
> In drm_dp_i2c_drain_msg we do msg.buffer += err which isn't
> legal for void *.

Well, this isn't pedantic C, it's GCC. There are tons of pointer
arithmetics for void pointers all over the kernel.

BR,
Jani.

> ---
>  include/drm/drm_dp_helper.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 62903bae..06f9a61f 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1058,7 +1058,7 @@ struct drm_dp_aux_msg {
>  	unsigned int address;
>  	u8 request;
>  	u8 reply;
> -	void *buffer;
> +	char *buffer;
>  	size_t size;
>  };

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux