Lines 686 and 688 seem to contain the same constant.
julia
On Wed, 16 May 2018, kbuild test robot wrote:
> CC: kbuild-all@xxxxxx
> CC: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> TO: Alex Deucher <alexander.deucher@xxxxxxx>
>
> tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
> head: dbf4f8b16fdef588f3d95fbb6d726dfe9663119b
> commit: 8251a44fae1ecc447975c442d4e0b5d6cf715d34 [62/63] drm/amdgpu: flag Vega20 as experimental
> :::::: branch date: 2 hours ago
> :::::: commit date: 2 hours ago
>
> >> drivers/gpu/drm/amd/amdgpu/soc15.c:686:3-24: duplicated argument to & or |
>
> git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git
> git remote update radeon-alex
> git checkout 8251a44fae1ecc447975c442d4e0b5d6cf715d34
> vim +686 drivers/gpu/drm/amd/amdgpu/soc15.c
>
> 220ab9bd1 Ken Wang 2017-03-06 605
> 220ab9bd1 Ken Wang 2017-03-06 606 static int soc15_common_early_init(void *handle)
> 220ab9bd1 Ken Wang 2017-03-06 607 {
> 220ab9bd1 Ken Wang 2017-03-06 608 struct amdgpu_device *adev = (struct amdgpu_device *)handle;
> 220ab9bd1 Ken Wang 2017-03-06 609
> 220ab9bd1 Ken Wang 2017-03-06 610 adev->smc_rreg = NULL;
> 220ab9bd1 Ken Wang 2017-03-06 611 adev->smc_wreg = NULL;
> 220ab9bd1 Ken Wang 2017-03-06 612 adev->pcie_rreg = &soc15_pcie_rreg;
> 220ab9bd1 Ken Wang 2017-03-06 613 adev->pcie_wreg = &soc15_pcie_wreg;
> 220ab9bd1 Ken Wang 2017-03-06 614 adev->uvd_ctx_rreg = &soc15_uvd_ctx_rreg;
> 220ab9bd1 Ken Wang 2017-03-06 615 adev->uvd_ctx_wreg = &soc15_uvd_ctx_wreg;
> 220ab9bd1 Ken Wang 2017-03-06 616 adev->didt_rreg = &soc15_didt_rreg;
> 220ab9bd1 Ken Wang 2017-03-06 617 adev->didt_wreg = &soc15_didt_wreg;
> 560460f28 Evan Quan 2017-07-03 618 adev->gc_cac_rreg = &soc15_gc_cac_rreg;
> 560460f28 Evan Quan 2017-07-03 619 adev->gc_cac_wreg = &soc15_gc_cac_wreg;
> 2f11fb028 Evan Quan 2017-07-04 620 adev->se_cac_rreg = &soc15_se_cac_rreg;
> 2f11fb028 Evan Quan 2017-07-04 621 adev->se_cac_wreg = &soc15_se_cac_wreg;
> 220ab9bd1 Ken Wang 2017-03-06 622
> 220ab9bd1 Ken Wang 2017-03-06 623 adev->asic_funcs = &soc15_asic_funcs;
> 220ab9bd1 Ken Wang 2017-03-06 624
> 220ab9bd1 Ken Wang 2017-03-06 625 adev->rev_id = soc15_get_rev_id(adev);
> 220ab9bd1 Ken Wang 2017-03-06 626 adev->external_rev_id = 0xFF;
> 220ab9bd1 Ken Wang 2017-03-06 627 switch (adev->asic_type) {
> 220ab9bd1 Ken Wang 2017-03-06 628 case CHIP_VEGA10:
> 220ab9bd1 Ken Wang 2017-03-06 629 adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
> 220ab9bd1 Ken Wang 2017-03-06 630 AMD_CG_SUPPORT_GFX_MGLS |
> 220ab9bd1 Ken Wang 2017-03-06 631 AMD_CG_SUPPORT_GFX_RLC_LS |
> 220ab9bd1 Ken Wang 2017-03-06 632 AMD_CG_SUPPORT_GFX_CP_LS |
> 220ab9bd1 Ken Wang 2017-03-06 633 AMD_CG_SUPPORT_GFX_3D_CGCG |
> 220ab9bd1 Ken Wang 2017-03-06 634 AMD_CG_SUPPORT_GFX_3D_CGLS |
> 220ab9bd1 Ken Wang 2017-03-06 635 AMD_CG_SUPPORT_GFX_CGCG |
> 220ab9bd1 Ken Wang 2017-03-06 636 AMD_CG_SUPPORT_GFX_CGLS |
> 220ab9bd1 Ken Wang 2017-03-06 637 AMD_CG_SUPPORT_BIF_MGCG |
> 220ab9bd1 Ken Wang 2017-03-06 638 AMD_CG_SUPPORT_BIF_LS |
> 220ab9bd1 Ken Wang 2017-03-06 639 AMD_CG_SUPPORT_HDP_LS |
> 220ab9bd1 Ken Wang 2017-03-06 640 AMD_CG_SUPPORT_DRM_MGCG |
> 220ab9bd1 Ken Wang 2017-03-06 641 AMD_CG_SUPPORT_DRM_LS |
> 220ab9bd1 Ken Wang 2017-03-06 642 AMD_CG_SUPPORT_ROM_MGCG |
> 220ab9bd1 Ken Wang 2017-03-06 643 AMD_CG_SUPPORT_DF_MGCG |
> 220ab9bd1 Ken Wang 2017-03-06 644 AMD_CG_SUPPORT_SDMA_MGCG |
> 220ab9bd1 Ken Wang 2017-03-06 645 AMD_CG_SUPPORT_SDMA_LS |
> 220ab9bd1 Ken Wang 2017-03-06 646 AMD_CG_SUPPORT_MC_MGCG |
> 220ab9bd1 Ken Wang 2017-03-06 647 AMD_CG_SUPPORT_MC_LS;
> 220ab9bd1 Ken Wang 2017-03-06 648 adev->pg_flags = 0;
> 220ab9bd1 Ken Wang 2017-03-06 649 adev->external_rev_id = 0x1;
> 220ab9bd1 Ken Wang 2017-03-06 650 break;
> 692069a1a Alex Deucher 2018-03-06 651 case CHIP_VEGA12:
> e4a387558 Evan Quan 2017-12-25 652 adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
> e4a387558 Evan Quan 2017-12-25 653 AMD_CG_SUPPORT_GFX_MGLS |
> e4a387558 Evan Quan 2017-12-25 654 AMD_CG_SUPPORT_GFX_CGCG |
> e4a387558 Evan Quan 2017-12-25 655 AMD_CG_SUPPORT_GFX_CGLS |
> e4a387558 Evan Quan 2017-12-25 656 AMD_CG_SUPPORT_GFX_3D_CGCG |
> e4a387558 Evan Quan 2017-12-25 657 AMD_CG_SUPPORT_GFX_3D_CGLS |
> e4a387558 Evan Quan 2017-12-25 658 AMD_CG_SUPPORT_GFX_CP_LS |
> e4a387558 Evan Quan 2017-12-25 659 AMD_CG_SUPPORT_MC_LS |
> e4a387558 Evan Quan 2017-12-25 660 AMD_CG_SUPPORT_MC_MGCG |
> e4a387558 Evan Quan 2017-12-25 661 AMD_CG_SUPPORT_SDMA_MGCG |
> e4a387558 Evan Quan 2017-12-25 662 AMD_CG_SUPPORT_SDMA_LS |
> e4a387558 Evan Quan 2017-12-25 663 AMD_CG_SUPPORT_BIF_MGCG |
> e4a387558 Evan Quan 2017-12-25 664 AMD_CG_SUPPORT_BIF_LS |
> e4a387558 Evan Quan 2017-12-25 665 AMD_CG_SUPPORT_HDP_MGCG |
> e4a387558 Evan Quan 2017-12-25 666 AMD_CG_SUPPORT_HDP_LS |
> e4a387558 Evan Quan 2017-12-25 667 AMD_CG_SUPPORT_ROM_MGCG |
> e4a387558 Evan Quan 2017-12-25 668 AMD_CG_SUPPORT_VCE_MGCG |
> e4a387558 Evan Quan 2017-12-25 669 AMD_CG_SUPPORT_UVD_MGCG;
> 692069a1a Alex Deucher 2018-03-06 670 adev->pg_flags = 0;
> f559fe2bc Feifei Xu 2017-12-14 671 adev->external_rev_id = adev->rev_id + 0x14;
> 692069a1a Alex Deucher 2018-03-06 672 break;
> 3ad6e3411 Feifei Xu 2018-01-26 673 case CHIP_VEGA20:
> 322c9a423 Evan Quan 2018-03-26 674 adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
> 322c9a423 Evan Quan 2018-03-26 675 AMD_CG_SUPPORT_GFX_MGLS |
> 322c9a423 Evan Quan 2018-03-26 676 AMD_CG_SUPPORT_GFX_CGCG |
> 322c9a423 Evan Quan 2018-03-26 677 AMD_CG_SUPPORT_GFX_CGLS |
> 322c9a423 Evan Quan 2018-03-26 678 AMD_CG_SUPPORT_GFX_3D_CGCG |
> 322c9a423 Evan Quan 2018-03-26 679 AMD_CG_SUPPORT_GFX_3D_CGLS |
> 322c9a423 Evan Quan 2018-03-26 680 AMD_CG_SUPPORT_GFX_CP_LS |
> 322c9a423 Evan Quan 2018-03-26 681 AMD_CG_SUPPORT_MC_LS |
> 322c9a423 Evan Quan 2018-03-26 682 AMD_CG_SUPPORT_MC_MGCG |
> 322c9a423 Evan Quan 2018-03-26 683 AMD_CG_SUPPORT_SDMA_MGCG |
> 322c9a423 Evan Quan 2018-03-26 684 AMD_CG_SUPPORT_SDMA_LS |
> 322c9a423 Evan Quan 2018-03-26 685 AMD_CG_SUPPORT_BIF_MGCG |
> 322c9a423 Evan Quan 2018-03-26 @686 AMD_CG_SUPPORT_BIF_LS |
> 322c9a423 Evan Quan 2018-03-26 687 AMD_CG_SUPPORT_HDP_MGCG |
> 322c9a423 Evan Quan 2018-03-26 688 AMD_CG_SUPPORT_BIF_LS |
> 322c9a423 Evan Quan 2018-03-26 689 AMD_CG_SUPPORT_ROM_MGCG |
> 322c9a423 Evan Quan 2018-03-26 690 AMD_CG_SUPPORT_VCE_MGCG |
> 322c9a423 Evan Quan 2018-03-26 691 AMD_CG_SUPPORT_UVD_MGCG;
> 3ad6e3411 Feifei Xu 2018-01-26 692 adev->pg_flags = 0;
> 3ad6e3411 Feifei Xu 2018-01-26 693 adev->external_rev_id = adev->rev_id + 0x28;
> 3ad6e3411 Feifei Xu 2018-01-26 694 break;
> 957c6fe18 Hawking Zhang 2016-12-27 695 case CHIP_RAVEN:
> 5c5928a23 Huang Rui 2017-01-18 696 adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
> 5c5928a23 Huang Rui 2017-01-18 697 AMD_CG_SUPPORT_GFX_MGLS |
> 5c5928a23 Huang Rui 2017-01-18 698 AMD_CG_SUPPORT_GFX_RLC_LS |
> 5c5928a23 Huang Rui 2017-01-18 699 AMD_CG_SUPPORT_GFX_CP_LS |
> 5c5928a23 Huang Rui 2017-01-18 700 AMD_CG_SUPPORT_GFX_3D_CGCG |
> 5c5928a23 Huang Rui 2017-01-18 701 AMD_CG_SUPPORT_GFX_3D_CGLS |
> 5c5928a23 Huang Rui 2017-01-18 702 AMD_CG_SUPPORT_GFX_CGCG |
> 5c5928a23 Huang Rui 2017-01-18 703 AMD_CG_SUPPORT_GFX_CGLS |
> 5c5928a23 Huang Rui 2017-01-18 704 AMD_CG_SUPPORT_BIF_MGCG |
> 5c5928a23 Huang Rui 2017-01-18 705 AMD_CG_SUPPORT_BIF_LS |
> 5c5928a23 Huang Rui 2017-01-18 706 AMD_CG_SUPPORT_HDP_MGCG |
> 5c5928a23 Huang Rui 2017-01-18 707 AMD_CG_SUPPORT_HDP_LS |
> 5c5928a23 Huang Rui 2017-01-18 708 AMD_CG_SUPPORT_DRM_MGCG |
> 5c5928a23 Huang Rui 2017-01-18 709 AMD_CG_SUPPORT_DRM_LS |
> c2cdb0ec0 Huang Rui 2017-05-05 710 AMD_CG_SUPPORT_ROM_MGCG |
> c2cdb0ec0 Huang Rui 2017-05-05 711 AMD_CG_SUPPORT_MC_MGCG |
> fe1a3b2e4 Huang Rui 2017-05-05 712 AMD_CG_SUPPORT_MC_LS |
> fe1a3b2e4 Huang Rui 2017-05-05 713 AMD_CG_SUPPORT_SDMA_MGCG |
> fe1a3b2e4 Huang Rui 2017-05-05 714 AMD_CG_SUPPORT_SDMA_LS;
> 400b6afba Huang Rui 2017-12-14 715 adev->pg_flags = AMD_PG_SUPPORT_SDMA;
> 400b6afba Huang Rui 2017-12-14 716
> fd299d2b6 Huang Rui 2017-12-15 717 if (adev->powerplay.pp_feature & PP_GFXOFF_MASK)
> fd299d2b6 Huang Rui 2017-12-15 718 adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |
> fd299d2b6 Huang Rui 2017-12-15 719 AMD_PG_SUPPORT_CP |
> fd299d2b6 Huang Rui 2017-12-15 720 AMD_PG_SUPPORT_RLC_SMU_HS;
> fd299d2b6 Huang Rui 2017-12-15 721
> 957c6fe18 Hawking Zhang 2016-12-27 722 adev->external_rev_id = 0x1;
> 957c6fe18 Hawking Zhang 2016-12-27 723 break;
> 220ab9bd1 Ken Wang 2017-03-06 724 default:
> 220ab9bd1 Ken Wang 2017-03-06 725 /* FIXME: not supported yet */
> 220ab9bd1 Ken Wang 2017-03-06 726 return -EINVAL;
> 220ab9bd1 Ken Wang 2017-03-06 727 }
> 220ab9bd1 Ken Wang 2017-03-06 728
> ab276632e Xiangliang Yu 2017-04-21 729 if (amdgpu_sriov_vf(adev)) {
> ab276632e Xiangliang Yu 2017-04-21 730 amdgpu_virt_init_setting(adev);
> ab276632e Xiangliang Yu 2017-04-21 731 xgpu_ai_mailbox_set_irq_funcs(adev);
> ab276632e Xiangliang Yu 2017-04-21 732 }
> ab276632e Xiangliang Yu 2017-04-21 733
> 220ab9bd1 Ken Wang 2017-03-06 734 return 0;
> 220ab9bd1 Ken Wang 2017-03-06 735 }
> 220ab9bd1 Ken Wang 2017-03-06 736
>
> :::::: The code at line 686 was first introduced by commit
> :::::: 322c9a423e7532c28f0a8653a8598324e8bc4659 drm/amd/powerplay: update vega20 cg flags
>
> :::::: TO: Evan Quan <evan.quan@xxxxxxx>
> :::::: CC: Alex Deucher <alexander.deucher@xxxxxxx>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
