On Tue 08 May 03:25 PDT 2018, kgunda@xxxxxxxxxxxxxx wrote: > On 2018-05-07 21:50, Bjorn Andersson wrote: > > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] > > > +- qcom,ovp > > > + Usage: optional > > > + Value type: <u32> > > > + Definition: mV; Over-voltage protection limit; > > > > The existing users of qcom,pm8941-wled depends on this being in V, so > > you can't change the unit. I suggest that you add a new "qcom,ovp-mv" > > property and make the driver fall back to looking for qcom,ovp if that > > isn't specified. > > > > PS. This is a very good example of why it is a good idea to not > > restructure and make changes at the same time - I almost missed this. > > > Actually I have checked the current kernel and none of the properties are > being configured from the device tree node. Hence, i thought it is the right > time modify the units to mV to support the PMI8998. > arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dts does. > You still want to have the qcom,ovp-mv, even though it is not being > configured from device tree ? Yes, please. > > > + For pm8941: one of 27000, 29000, 32000, 35000 > > > + Default: 29000 mV > > > + For pmi8998: one of 18100, 19600, 29600, 31100 > > > + Default: 29600 mV > > > + Regards, Bjorn _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
