Re: [PATCH] drm/radeon/kms: clean up CS flags chunk processing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 21, 2011 at 3:41 PM,  <alexdeucher@xxxxxxxxx> wrote:
> From: Alex Deucher <alexander.deucher@xxxxxxx>
>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
Reviewed-by: Jerome Glisse <jglisse@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/radeon/radeon_cs.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
> index de3cac0..e30a36f 100644
> --- a/drivers/gpu/drm/radeon/radeon_cs.c
> +++ b/drivers/gpu/drm/radeon/radeon_cs.c
> @@ -203,10 +203,9 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
>                }
>                if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_FLAGS) {
>                        p->chunk_flags_idx = i;
> -               }
> -               if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_FLAGS &&
> -                   !p->chunks[i].length_dw) {
> -                       return -EINVAL;
> +                       /* zero length flags aren't useful */
> +                       if (p->chunks[i].length_dw == 0)
> +                               return -EINVAL;
>                }
>
>                p->chunks[i].length_dw = user_chunk.length_dw;
> --
> 1.7.3.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux