Re: [PATCH RESEND 1/2] drm/msm: remove unbalanced mutex unlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, May 03, 2018 02:24 PM, Rob Clark wrote:
> On Thu, May 3, 2018 at 8:00 AM, Daniel Mack <daniel@xxxxxxxxxx> wrote:
>> This regression stems from 0e08270a1f01 ("drm/msm: Separate locking of
>> buffer resources from struct_mutex").
>>
>> Signed-off-by: Daniel Mack <daniel@xxxxxxxxxx>
>> Cc: Sushmita Susheelendra <ssusheel@xxxxxxxxxxxxxx>
>> Cc: Rob Clark <rclark@xxxxxxxxxx>
>> Fixes: 0e08270a1f01 ("drm/msm: Separate locking of buffer resources from struct_mutex")
>> ---
>> I'm resending these two patches as I got no reply last time.
> 
> I've applied these two to msm-next.  Sorry I missed them before...
> for some reason they don't seem to show up in the dri-devel
> patchworks[1]

No problem, and thanks for applying them :)


Daniel


> 
> BR,
> -R
> 
> [1] https://patchwork.freedesktop.org/project/dri-devel/series/
> 
>>
>>  drivers/gpu/drm/msm/dsi/dsi_host.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> index 0f7324a686ca..27637d8a99ff 100644
>> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
>> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> @@ -994,7 +994,6 @@ static int dsi_tx_buf_alloc(struct msm_dsi_host *msm_host, int size)
>>
>>                 ret = msm_gem_get_iova(msm_host->tx_gem_obj,
>>                                 priv->kms->aspace, &iova);
>> -               mutex_unlock(&dev->struct_mutex);
>>                 if (ret) {
>>                         pr_err("%s: failed to get iova, %d\n", __func__, ret);
>>                         return ret;
>> --
>> 2.14.3
>>

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux