|
On 4/27/2018 7:35 PM, Ville Syrjälä
wrote:
On Fri, Apr 27, 2018 at 05:44:54PM +0530, Nautiyal, Ankit K wrote:From: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx> We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio information, from a connector's modelist, if the user-space has not set the aspect ratio DRM client cap. However if such a mode is unique in the list, it is kept in the list, with aspect-ratio flags reset. Cc: Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> Cc: Shashank Sharma <shashank.sharma@xxxxxxxxx> Cc: Jose Abreu <jose.abreu@xxxxxxxxxxxx> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx> V3: As suggested by Ville, modified the mechanism of pruning of modes with aspect-ratio, if the aspect-ratio is not supported. Instead of straight away pruning such a mode, the mode is retained with aspect ratio bits set to zero, provided it is unique. V4: rebase V5: Addressed review comments from Ville: -used a pointer to store last valid mode. -avoided, modifying of picture_aspect_ratio in kernel mode, instead only flags bits of user mode are reset (if aspect-ratio is not supported). V6: As suggested by Ville, corrected the mode pruning logic and elaborated the mode pruning logic and the assumptions taken. V7: rebase V8: rebase V9: rebase V10: rebase V11: Fixed the issue caused in kms_3d test, and enhanced the pruning logic to correctly identify and prune modes with aspect-ratio, if aspect-ratio cap is not set. V12: As suggested by Ville, added another list_head in drm_mode_display to traverse the list of exposed modes and avoided duplication of modes. --- drivers/gpu/drm/drm_connector.c | 52 ++++++++++++++++++++++++++++++++++------- include/drm/drm_modes.h | 9 +++++++ 2 files changed, 53 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index b3cde89..e12964b 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -1531,15 +1531,35 @@ static struct drm_encoder *drm_connector_get_encoder(struct drm_connector *conne return connector->encoder; } -static bool drm_mode_expose_to_userspace(const struct drm_display_mode *mode, - const struct drm_file *file_priv) +static bool +drm_mode_expose_to_userspace(const struct drm_display_mode *mode, + const struct list_head *modelist, + const struct drm_file *file_priv) { /* * If user-space hasn't configured the driver to expose the stereo 3D * modes, don't expose them. */ + struct drm_display_mode *mode_itr; +This is clearly misplaced. It should be before the comment. Hmm, atually better move it into the aspect ratio if block since it's not needed elsewhere. That makes sense, will move it to the aspect-ratio block.
Alright. Will change the name to export_list. I hope you mean LIST_HEAD(export_list); Oh yes, list_del () is not required, the deletion of the last mode, will automatically set the next and prev of the list_head to itself. Since we don't actually care about exp_head outside of this function I think we can just leave the stale pointers in place. No one else is supposed to look at them, a fact we should probaly also include in the documentation. Ok, so I will let the stale pointers in place, and explain the reasoning as comments.
Yeah right, shortening export_head to exp_head didn't do much :) Will change it to export_head. Regards, Ankit + * + * struct list_head for modes to be exposed to the userspace. + * + */ + struct list_head exp_head; + }; /** -- 2.7.4 |
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
