On Tue, Apr 24, 2018 at 03:15:17PM +0200, Luc Van Oostenryck wrote: > The method struct drm_connector_helper_funcs::mode_valid is defined > as returning an 'enum drm_mode_status' but the driver implementation > for this method uses an 'int' for it. > > Fix this by using 'enum drm_mode_status' in the driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> hisilicon, mgag200 and udl patches also merged to drm-misc-next. -Daniel > --- > drivers/gpu/drm/udl/udl_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c > index c3dc1fd20..09dc585aa 100644 > --- a/drivers/gpu/drm/udl/udl_connector.c > +++ b/drivers/gpu/drm/udl/udl_connector.c > @@ -105,7 +105,7 @@ static int udl_get_modes(struct drm_connector *connector) > return 0; > } > > -static int udl_mode_valid(struct drm_connector *connector, > +static enum drm_mode_status udl_mode_valid(struct drm_connector *connector, > struct drm_display_mode *mode) > { > struct udl_device *udl = connector->dev->dev_private; > -- > 2.17.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel