Re: [PATCH] Intel: Add a Kaby Lake PCI ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 24, 2018 at 10:42:26AM -0700, Rodrigo Vivi wrote:
> On Mon, Apr 23, 2018 at 03:08:31PM -0700, matthew.s.atwood@xxxxxxxxx wrote:
> > From: Matt Atwood <matthew.s.atwood@xxxxxxxxx>
> 
> Based on kernel commit '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
> 
> (I'm adding this and pushing. Thanks for the patch)
> 
> > 
> > Signed-off-by: Matt Atwood <matthew.s.atwood@xxxxxxxxx>
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

ops... I take it back... sorry

I just reviewed the id and had match the
spec and kernel patch, but I had forgotten here we need a different
identifier for this platform.

You are just redefining the existent one. You need to define a new
one and add enable it.

> 
> > ---
> >  intel/intel_chipset.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
> > index 01d250e..6b8fd1d 100644
> > --- a/intel/intel_chipset.h
> > +++ b/intel/intel_chipset.h
> > @@ -203,6 +203,7 @@
> >  #define PCI_CHIP_KABYLAKE_ULX_GT2	0x591E
> >  #define PCI_CHIP_KABYLAKE_DT_GT2	0x5912
> >  #define PCI_CHIP_KABYLAKE_M_GT2		0x5917
> > +#define PCI_CHIP_KABYLAKE_M_GT2		0x591C
> >  #define PCI_CHIP_KABYLAKE_DT_GT1	0x5902
> >  #define PCI_CHIP_KABYLAKE_HALO_GT2	0x591B
> >  #define PCI_CHIP_KABYLAKE_HALO_GT4	0x593B
> > -- 
> > 2.7.4
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux