Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI

[Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxx>]

Hi Maxime, 

Il 24 apr 2018 10:41, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> ha scritto:

Hi,

On Mon, Apr 23, 2018 at 04:37:33PM +0200, Giulio Benetti wrote:
> Il 22/03/2018 19:05, Maxime Ripard ha scritto:
> > On Wed, Mar 21, 2018 at 09:03:13PM +0100, Giulio Benetti wrote:
> > > The A20-Linova1-7 HMI, also called Q027_2_F which is printed on production
> > > label, is an industrial Human Machine Interface.
> > > It features:
> > > - 512MB DDR RAM
> > > - 1 Sd-card >= 4GB
> > > - 1 Usb otg(programmable via software) with A-Usb Connector
> > > - 1 Usb host
> > > - 1 Buzzer
> > > - 1 Input for LiPo
> > > - 1 Relay to signal absence of power supply
> > > - 1 External Rtc with 56 bytes of ram + CR2032 battery
> > > - 1 7" 24-bits Tft 800x480 with PCap on
> > > - 1 Mono audio 1-watt amplifier
> > > - 1 RS485 port
> > > - 1 Power On Line through +12Vdc reaching 57.600baud,
> > >    from where it can be supplied and placed in a network of 50 units
> > > - exposed jtag pins
> > >
> > > HMI is supplied from +12Vdc.
> > > Ethernet is absent, so for debugging, need to enable rndis on Usb otg
> > > port through an A-A usb cable.
> > > It comes in different flavours for connector types and can be found with
> > > umounted features as requested by customers.
> >
> > So this is essentially the same board than in patch 6, but with a
> > different screen?
> >
> > You should have a single DT then, and handle the two different panels
> > using DT overlays.
>
> Ok for having different DT overlays.
> But do I have to submit them as patches? Or keep them in my company's repo?
> I ask you this because this involves sending also patches for displays
> and other little modifications to mainline ex:
> - rgb888 pins
> - 2 simple-panels
> - 1 uart iomux pins
> etc.
>
> If I don't submit those overlays, the other patches wouldn't make sense
> alone as I've seen, just like rgb888 pins.

We don't have a repo for overlays yet

Ok I can provide them on my company Repo. 

But, sorry if insist, I would try to explain better how it's made LiNova, because I think I didn't provide enough information about it:

LiNova1 is not a board with various headers to connect other peripherals such display, pcap etc. 

It's an HMI that I would consider the same as a Tablet, because it has a plastic enclosure also. 

So I would like to understand how to manage it in the best way. 

Try to consider LiNova1 as a Tablet series, with following list:

LiNova1 4.3" ctp

LiNova1 7" ctp

LiNova1 10.1" ctp

LiNova1 4.3" rtp

LiNova1 7" rtp

LiNova1 10.1" rtp

Every of those has a slightly different BOM, so they are 6 different boards with a common base(uP, ram). And same pcb. 

So I don't know if submit only the common base and provide separately on our github DT-overlays, or provide as many dts patches as the HMI number with a base dtsi.

Basically Micronova provides entire system without the capability to hack hardware adding shields of various type.

There are also other 2 LiNova:

LiNova2 and LiNova3

So I understand that this could lead to 18 different dts files and 3 dtsi files. 

But with Tablet it should be the same way. 

For sure people would be more interested on famous tablets instead of our HMI. 

Sorry if I bother you again but I wanted to understand better. 

> > > +&usb_otg {
> > > + dr_mode = "otg";
> >
> > You're saying that this is a USB-A connector? Then it's not OTG since
> > it doesn't have an ID pin, this is an host.
>
> Right, with a special overlay I will activate Usb Device for RNDIS,
> so modified as host

That doesn't really make much sense. The USB OTG is wired only using a
daughter board?

My fault, I've meant "peripheral" in one case and "host" in another case. 

Usually "host". 

Are there problem with this? 

I can't understand why it shouldn't make sense. 

There is no daughter board. 

Thank you very much in advance for you patience :) 

Giulio 

> One last question:
> now I have some patch already reviewed-by.
> Do I have to re-submit entire patchset?

Yes

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel