Please use "PATCH hwc" for drm_hwcomposer patches. On Mon, Apr 23, 2018 at 7:06 PM, John Stultz <john.stultz@xxxxxxxxxx> wrote: > The drm_hwcomposer has its own GL pre-compositor which is used > to squish layers when there are more layers then planes on the > display hardware. In many ways this duplicates the client-side > GL compositing that is done in SurfaceFlinger, but in theory can > be more highly optimized for the hardware. > > Unfortunately, due to these optimizations, the drm_hwcomposer's > pre-compositor becomes somewhat hardware specific (originally > targeting nvidia hardware, I believe). > > So on some hardware, the gl precompositor may not actually > initialize due to hardware missing features, or the hardware > supporting different shader APIs. > > Rather then try to rework the drm_hwcomposers precompositor > to be more generic, I instead suggest that when the > precompositor fails to initialize, we simply fall back to the > already more widely compatible client compositor in > SurfaceFlinger. > > Thus, this patch cleans up some of the precompositor > initialization, which didn't handle failures well. > > Feedback or alternative ideas would be greatly appreciated! > > Cc: Marissa Wall <marissaw@xxxxxxxxxx> > Cc: Sean Paul <seanpaul@xxxxxxxxxx> > Cc: Dmitry Shmidt <dimitrysh@xxxxxxxxxx> > Cc: Robert Foss <robert.foss@xxxxxxxxxxxxx> > Cc: Matt Szczesiak <matt.szczesiak@xxxxxxx> > Cc: Liviu Dudau <Liviu.Dudau@xxxxxxx> > Cc: David Hanna <david.hanna11@xxxxxxxxx> > Cc: Rob Herring <rob.herring@xxxxxxxxxx> > Cc: Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@xxxxxxx> > Cc: Alistair Strachan <astrachan@xxxxxxxxxx> > Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx> > --- > drmdisplaycompositor.cpp | 40 +++++++++++++++++++++------------------- > drmdisplaycompositor.h | 3 +++ > 2 files changed, 24 insertions(+), 19 deletions(-) Both patches look good to me. Reviewed-by: Rob Herring <robh@xxxxxxxxxx> _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
