On Saturday, April 21, 2018 6:55:17 PM CEST Krzysztof Kozlowski wrote:
> On Fri, Apr 20, 2018 at 6:32 PM, Paweł Chmiel
> <pawel.mikolaj.chmiel@xxxxxxxxx> wrote:
> > From: Tomasz Figa <tomasz.figa@xxxxxxxxx>
> >
> > This patch adds support for FIMD variant found on S5PV210 SoC.
> > Except CLKSEL bit availability, it is identical to Exynos4210.
> >
> > Tested-by: Paweł Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx>
> > Signed-off-by: Tomasz Figa <tomasz.figa@xxxxxxxxx>
>
> You need to add your Signed-off-by here as well. It is necessary every
> time you touch a patch (and sending it is also a "touch" action).
Hi
Thanks for feedback, i've send a v2 version of this patchset with this issue fixed.
>
> Best regards,
> Krzysztof
>
> > ---
> > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > index d42ae2bc3e56..01b1570d0c3a 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > @@ -121,6 +121,12 @@ static struct fimd_driver_data s3c64xx_fimd_driver_data = {
> > .has_limited_fmt = 1,
> > };
> >
> > +static struct fimd_driver_data s5pv210_fimd_driver_data = {
> > + .timing_base = 0x0,
> > + .has_shadowcon = 1,
> > + .has_clksel = 1,
> > +};
> > +
> > static struct fimd_driver_data exynos3_fimd_driver_data = {
> > .timing_base = 0x20000,
> > .lcdblk_offset = 0x210,
> > @@ -193,6 +199,8 @@ struct fimd_context {
> > static const struct of_device_id fimd_driver_dt_match[] = {
> > { .compatible = "samsung,s3c6400-fimd",
> > .data = &s3c64xx_fimd_driver_data },
> > + { .compatible = "samsung,s5pv210-fimd",
> > + .data = &s5pv210_fimd_driver_data },
> > { .compatible = "samsung,exynos3250-fimd",
> > .data = &exynos3_fimd_driver_data },
> > { .compatible = "samsung,exynos4210-fimd",
> > --
> > 2.7.4
> >
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
