On 14 April 2018 at 04:49, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > When CONFIG_MMU_NOTIFIER is not enabled, struct mmu_notifier has an > incomplete type definition, which causes build errors. > > ../drivers/gpu/drm/amd/amdkfd/kfd_priv.h:607:22: error: field 'mmu_notifier' has incomplete type > ../include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type > ../include/linux/kernel.h:980:18: error: dereferencing pointer to incomplete type > ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:434:2: error: implicit declaration of function 'mmu_notifier_unregister_no_release' [-Werror=implicit-function-declaration] > ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:435:2: error: implicit declaration of function 'mmu_notifier_call_srcu' [-Werror=implicit-function-declaration] > ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:438:21: error: variable 'kfd_process_mmu_notifier_ops' has initializer but incomplete type > ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: error: unknown field 'release' specified in initializer > ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: excess elements in struct initializer [enabled by default] > ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: (near initialization for 'kfd_process_mmu_notifier_ops') [enabled by default] > ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:534:2: error: implicit declaration of function 'mmu_notifier_register' [-Werror=implicit-function-declaration] > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Oded Gabbay <oded.gabbay@xxxxxxxxx> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx Tested-by: Anders Roxell <anders.roxell@xxxxxxxxxx> > --- > From linux-next, not mmotm, but found in mmotm builds. > > drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- mmotm-2018-0413-1728.orig/drivers/gpu/drm/amd/amdkfd/Kconfig > +++ mmotm-2018-0413-1728/drivers/gpu/drm/amd/amdkfd/Kconfig > @@ -6,5 +6,6 @@ config HSA_AMD > tristate "HSA kernel driver for AMD GPU devices" > depends on DRM_AMDGPU && X86_64 > imply AMD_IOMMU_V2 > + select MMU_NOTIFIER > help > Enable this if you want to use HSA features on AMD GPU devices. > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
