Reviewed-by: yannick fertre <yannick.fertre@xxxxxx> On 04/10/2018 03:53 PM, Philippe Cornu wrote: > Fix the warning > "warn: variable dereferenced before check 'crtc' (see line 390)" > by removing unnecessary checks as ltdc_crtc_update_clut() is > only called from ltdc_crtc_atomic_flush() where crtc and > crtc->state are not NULL. > > Many thanks to Dan Carpenter for the bug report > https://lists.freedesktop.org/archives/dri-devel/2018-February/166918.html > > Signed-off-by: Philippe Cornu <philippe.cornu@xxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/gpu/drm/stm/ltdc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index 061d2b6e5157..e3121d9e4230 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -392,9 +392,6 @@ static void ltdc_crtc_update_clut(struct drm_crtc *crtc) > u32 val; > int i; > > - if (!crtc || !crtc->state) > - return; > - > if (!crtc->state->color_mgmt_changed || !crtc->state->gamma_lut) > return; > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
