On Monday, 2018-03-26 15:00:01 +0100, Emil Velikov wrote:
> On 26 March 2018 at 14:57, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote:
> > On Mon, 26 Mar 2018, Eric Engestrom <eric.engestrom@xxxxxxxxxx> wrote:
> >> Signed-off-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx>
> >> ---
> >> xf86drm.c | 28 ++++++++++++++--------------
> >> 1 file changed, 14 insertions(+), 14 deletions(-)
> >>
> >> diff --git a/xf86drm.c b/xf86drm.c
> >> index 3a9d0ed2cc9b196ae7d1..b6e5d8cc1bb50ffe75a2 100644
> >> --- a/xf86drm.c
> >> +++ b/xf86drm.c
> >> @@ -2823,7 +2823,7 @@ static char *drmGetMinorNameForFD(int fd, int type)
> >> struct stat sbuf;
> >> const char *name = drmGetMinorName(type);
> >> int len;
> >> - char dev_name[64], buf[64];
> >> + char *dev_name, buf[64];
> >> int maj, min;
> >>
> >> if (!name)
> >> @@ -2848,20 +2848,22 @@ static char *drmGetMinorNameForFD(int fd, int type)
> >>
> >> while ((ent = readdir(sysdir))) {
> >> if (strncmp(ent->d_name, name, len) == 0) {
> >> - snprintf(dev_name, sizeof(dev_name), DRM_DIR_NAME "/%s",
> >> - ent->d_name);
> >> + if (asprintf(&dev_name, DRM_DIR_NAME "/%s",
> >
> > Just noting in passing that asprintf is a GNU extension, is that okay?
> >
> Was going to mention the same thing. Also POSIX please add it to the
> next version ;-)
> It doesn't seem to make the code shorter, so I'd go with let's drop this?
Those were just some local changes I had done at some random point when
coming across stuff that I thought could be better. I just sent them now
since my local changes will be lost by me leaving my current job, and
I didn't care enough to push them on a branch somewhere (:
Either these were thought to be good by someone else, or, as it is,
they're not and I'm dropping all three :)
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
