Am 01.04.2018 um 19:45 schrieb Ilia Mirkin:
On Sun, Apr 1, 2018 at 1:39 PM, Christian König
<christian.koenig@xxxxxxx> wrote:
Am 30.03.2018 um 22:45 schrieb Takashi Iwai:
amdgpu driver lacks of modeset module option other drm drivers provide
for enforcing or disabling the driver load. Interestingly, the
amdgpu_mode variable declaration is already found in the header file,
but the actual implementation seems to have been forgotten.
This patch adds the missing piece.
NAK, modesetting is mandatory for amdgpu and we should probably remove the
option to disable it from other DRM drivers without UMS support as well
(pretty much all of them now).
If you want to prevent a driver from loading I think the correct way to do
so is to give modprobe.blacklist=amdgpu on the kernel commandline.
That would remove the possibility to prevent the driver from loading when it
is compiled in, but I don't see much of a problem with that.
Having a way to kill the graphics driver is a very useful debugging
tool, and also a quick and easy way to get out of an unpleasant
situation where graphics are messed up / system hangs / etc. The
modprobe blacklist kernel arg only works in certain environments (and
only if it's a module).
Every other DRM driver has this and this is a well-documented
workaround for "graphics are messed up when I install linux", why not
allow a uniform experience for the end users who are just trying to
get their systems up and running?
Because it is not well documented and repeated over and over again in
drivers.
The problem is that people don't realized that the driver isn't loaded
at all without the modeset=0 module option and demand fixing the
resulting bad performance without modesetting.
I can't count how often I had to explain that this approach won't work.
We could rename it to something like disable_gfx_accel or something like
that to make this clear.
Christian.
-ilia
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
