Re: [PATCH v5 1/1] drm/xen-front: Add support for Xen PV display frontend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Oleksandr,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on next-20180329]
[cannot apply to v4.16-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Oleksandr-Andrushchenko/drm-xen-front-Add-support-for-Xen-PV-display-frontend/20180329-191740
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/xen/xen_drm_front.c:484:13: sparse: undefined identifier 'drm_dev_enter'
   drivers/gpu/drm/xen/xen_drm_front.c:487:17: sparse: undefined identifier 'drm_dev_exit'
   drivers/gpu/drm/xen/xen_drm_front.c:484:26: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front.c:487:29: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front.c: In function 'xen_drm_drv_free_object_unlocked':
>> drivers/gpu/drm/xen/xen_drm_front.c:484:6: error: implicit declaration of function 'drm_dev_enter'; did you mean 'drm_dev_unref'? [-Werror=implicit-function-declaration]
     if (drm_dev_enter(obj->dev, &idx)) {
         ^~~~~~~~~~~~~
         drm_dev_unref
>> drivers/gpu/drm/xen/xen_drm_front.c:487:3: error: implicit declaration of function 'drm_dev_exit'; did you mean 'drm_dev_init'? [-Werror=implicit-function-declaration]
      drm_dev_exit(idx);
      ^~~~~~~~~~~~
      drm_dev_init
   cc1: some warnings being treated as errors
--
   drivers/gpu/drm/xen/xen_drm_front_kms.c:40:13: sparse: undefined identifier 'drm_dev_enter'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:43:17: sparse: undefined identifier 'drm_dev_exit'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:119:14: sparse: undefined identifier 'drm_dev_enter'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:132:9: sparse: undefined identifier 'drm_dev_exit'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:141:13: sparse: undefined identifier 'drm_dev_enter'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:144:17: sparse: undefined identifier 'drm_dev_exit'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:258:14: sparse: undefined identifier 'drm_dev_enter'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:274:9: sparse: undefined identifier 'drm_dev_exit'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:296:19: sparse: incorrect type in initializer (different argument counts)
   drivers/gpu/drm/xen/xen_drm_front_kms.c:296:19:    expected void ( *enable )( ... )
   drivers/gpu/drm/xen/xen_drm_front_kms.c:296:19:    got void ( *<noident> )( ... )
   drivers/gpu/drm/xen/xen_drm_front_kms.c:40:26: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:43:29: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:119:27: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:132:21: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:141:26: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:144:29: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:258:27: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:274:21: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c: In function 'fb_destroy':
>> drivers/gpu/drm/xen/xen_drm_front_kms.c:40:6: error: implicit declaration of function 'drm_dev_enter'; did you mean 'drm_dev_unref'? [-Werror=implicit-function-declaration]
     if (drm_dev_enter(fb->dev, &idx)) {
         ^~~~~~~~~~~~~
         drm_dev_unref
>> drivers/gpu/drm/xen/xen_drm_front_kms.c:43:3: error: implicit declaration of function 'drm_dev_exit'; did you mean 'drm_dev_init'? [-Werror=implicit-function-declaration]
      drm_dev_exit(idx);
      ^~~~~~~~~~~~
      drm_dev_init
   drivers/gpu/drm/xen/xen_drm_front_kms.c: At top level:
   drivers/gpu/drm/xen/xen_drm_front_kms.c:296:12: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .enable = display_enable,
               ^~~~~~~~~~~~~~
   drivers/gpu/drm/xen/xen_drm_front_kms.c:296:12: note: (near initialization for 'display_funcs.enable')
   cc1: some warnings being treated as errors

sparse warnings: (new ones prefixed by >>)

   drivers/gpu/drm/xen/xen_drm_front.c:484:13: sparse: undefined identifier 'drm_dev_enter'
   drivers/gpu/drm/xen/xen_drm_front.c:487:17: sparse: undefined identifier 'drm_dev_exit'
>> drivers/gpu/drm/xen/xen_drm_front.c:484:26: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front.c:487:29: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front.c: In function 'xen_drm_drv_free_object_unlocked':
   drivers/gpu/drm/xen/xen_drm_front.c:484:6: error: implicit declaration of function 'drm_dev_enter'; did you mean 'drm_dev_unref'? [-Werror=implicit-function-declaration]
     if (drm_dev_enter(obj->dev, &idx)) {
         ^~~~~~~~~~~~~
         drm_dev_unref
   drivers/gpu/drm/xen/xen_drm_front.c:487:3: error: implicit declaration of function 'drm_dev_exit'; did you mean 'drm_dev_init'? [-Werror=implicit-function-declaration]
      drm_dev_exit(idx);
      ^~~~~~~~~~~~
      drm_dev_init
   cc1: some warnings being treated as errors
--
   drivers/gpu/drm/xen/xen_drm_front_kms.c:40:13: sparse: undefined identifier 'drm_dev_enter'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:43:17: sparse: undefined identifier 'drm_dev_exit'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:119:14: sparse: undefined identifier 'drm_dev_enter'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:132:9: sparse: undefined identifier 'drm_dev_exit'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:141:13: sparse: undefined identifier 'drm_dev_enter'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:144:17: sparse: undefined identifier 'drm_dev_exit'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:258:14: sparse: undefined identifier 'drm_dev_enter'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:274:9: sparse: undefined identifier 'drm_dev_exit'
   drivers/gpu/drm/xen/xen_drm_front_kms.c:296:19: sparse: incorrect type in initializer (different argument counts) @@    expected void ( *enable )( ... ) @@    got void ( *enable )( ... ) @@
   drivers/gpu/drm/xen/xen_drm_front_kms.c:296:19:    expected void ( *enable )( ... )
   drivers/gpu/drm/xen/xen_drm_front_kms.c:296:19:    got void ( *<noident> )( ... )
>> drivers/gpu/drm/xen/xen_drm_front_kms.c:40:26: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:43:29: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:119:27: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:132:21: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:141:26: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:144:29: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:258:27: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c:274:21: sparse: call with no type!
   drivers/gpu/drm/xen/xen_drm_front_kms.c: In function 'fb_destroy':
   drivers/gpu/drm/xen/xen_drm_front_kms.c:40:6: error: implicit declaration of function 'drm_dev_enter'; did you mean 'drm_dev_unref'? [-Werror=implicit-function-declaration]
     if (drm_dev_enter(fb->dev, &idx)) {
         ^~~~~~~~~~~~~
         drm_dev_unref
   drivers/gpu/drm/xen/xen_drm_front_kms.c:43:3: error: implicit declaration of function 'drm_dev_exit'; did you mean 'drm_dev_init'? [-Werror=implicit-function-declaration]
      drm_dev_exit(idx);
      ^~~~~~~~~~~~
      drm_dev_init
   drivers/gpu/drm/xen/xen_drm_front_kms.c: At top level:
   drivers/gpu/drm/xen/xen_drm_front_kms.c:296:12: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .enable = display_enable,
               ^~~~~~~~~~~~~~
   drivers/gpu/drm/xen/xen_drm_front_kms.c:296:12: note: (near initialization for 'display_funcs.enable')
   cc1: some warnings being treated as errors

vim +484 drivers/gpu/drm/xen/xen_drm_front.c

   478	
   479	static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
   480	{
   481		struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
   482		int idx;
   483	
 > 484		if (drm_dev_enter(obj->dev, &idx)) {
   485			xen_drm_front_dbuf_destroy(drm_info->front_info,
   486					xen_drm_front_dbuf_to_cookie(obj));
 > 487			drm_dev_exit(idx);
   488		} else
   489			dbuf_free(&drm_info->front_info->dbuf_list,
   490					xen_drm_front_dbuf_to_cookie(obj));
   491	
   492		xen_drm_front_gem_free_object_unlocked(obj);
   493	}
   494	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux