Hi Daniel, On 03/27/2018 05:51 PM, Daniel Vetter wrote: > On Mon, Feb 26, 2018 at 01:16:04PM +0100, Philippe Cornu wrote: >> This patch clarifies the adjusted_mode documentation >> for a bridge directly connected to a crtc. >> >> Signed-off-by: Philippe Cornu <philippe.cornu@xxxxxx> >> --- >> This patch is linked to the discussion https://lkml.org/lkml/2018/1/25/367 > > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> Many thanks for the review. > > Aside, and kinda why I noticed this patch to begin with: You have drm-misc > commit rights, but you seem to not use that. And with 18 patches in the > 4.17 cycle you're the top contributor who's not pushing his own patches. > > What's the hold-up? Tools don't work, or something else? I really think > regular contributors should just push their own stuff themselves (after > appropriate review ofc). > -Daniel > I still consider myself a drm “beginner”, my first patch in drm was last summer so less than 1 year ago. However, thank you for your encouraging return, I will immediately study the matter (dim...) and prepare myself. Thank you, Philippe :-) >> >> include/drm/drm_bridge.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h >> index 3270fec46979..b5f3c070467c 100644 >> --- a/include/drm/drm_bridge.h >> +++ b/include/drm/drm_bridge.h >> @@ -177,7 +177,8 @@ struct drm_bridge_funcs { >> * pipeline has been called already. If the bridge is the first element >> * then this would be &drm_encoder_helper_funcs.mode_set. The display >> * pipe (i.e. clocks and timing signals) is off when this function is >> - * called. >> + * called. If the bridge is connected to the crtc, the adjusted_mode >> + * parameter is the one defined in &drm_crtc_state.adjusted_mode. >> */ >> void (*mode_set)(struct drm_bridge *bridge, >> struct drm_display_mode *mode, >> -- >> 2.15.1 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
