> So having looked at the patch itself, I don't dislike the notion of > making sure certain fields are nicely initialized. So I don't hate the > patch itself, but quite frankly, to me it doesn't smell even > *remotely* like "regression fix". I don't think this is something that > has ever worked. Well just for completeness I tracked it down to 724c80e1d630296d1324859e964d80d35007d83c which git describe shows as v2.6.36-rc5-456-g724c80e, so while it is a technical regression, it took a long time for anyone to notice. I think we probably need a more invasive patch in any case, as there is still a race between when the drm midlayer calls pci_set_master and the sanity enforcement, which we should close by moving pci_set_master into the drivers (midlayer design yet again for the win). so I'll leave it for -next. Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
