On Tue, Mar 27, 2018 at 10:27:44AM +0200, Paul Kocialkowski wrote: > > > +bool sun4i_format_is_rgb(uint32_t format); > > > +bool sun4i_format_is_yuv(uint32_t format); > > > +bool sun4i_format_is_yuv411(uint32_t format); > > > +bool sun4i_format_is_yuv420(uint32_t format); > > > +bool sun4i_format_is_yuv422(uint32_t format); > > > +bool sun4i_format_is_yuv444(uint32_t format); > > > +bool sun4i_format_is_packed(uint32_t format); > > > +bool sun4i_format_is_semiplanar(uint32_t format); > > > +bool sun4i_format_is_planar(uint32_t format); > > > +bool sun4i_format_supports_tiling(uint32_t format); > > > > If we're going to add so many of them, then we should really consider > > to move them to drm_fourcc.c instead. Every one has some variation of > > some of these functions, we don't really need to duplicate it all the > > time. > > Should I try to get that through in this patchset and have sun4i-drm > be their first user? Also, does introducing such a change require > identifying duplicates of these functions in each DRM driver's > codebase? I guess converting at least one of them would prove how usable it would be to other drivers, but I won't ask you to convert all of them as part of this serie :) Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
