On Thu, Mar 22, 2018 at 9:51 AM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote: > On 20 March 2018 at 18:17, Eric Engestrom <eric.engestrom@xxxxxxxxxx> wrote: >> On Tuesday, 2018-03-20 17:48:23 +0000, Emil Velikov wrote: >>> From: John Stultz <john.stultz@xxxxxxxxxx> >>> >>> Building libdrm under AOSP, we see the following build warning: >>> external/libdrm/xf86drm.c:2861:12: warning: 'readdir_r' is deprecated: readdir_r is deprecated; use readdir instead [-Wdeprecated-declarations] >>> while (readdir_r(sysdir, pent, &ent) == 0 && ent != NULL) { >>> ^ >>> >>> Building on Linux with glibc produces the same warning. >>> Thus, this patch replaces readdir_r with readdir. >>> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102031 >>> Cc: Robert Foss <robert.foss@xxxxxxxxxxxxx> >>> Cc: Rob Herring <robh@xxxxxxxxxx> >>> Cc: Stefan Schake <stschake@xxxxxxxxx> >>> Cc: John Stultz <john.stultz@xxxxxxxxxx> >>> Cc: Eric Engestrom <eric.engestrom@xxxxxxxxxx> >>> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx> >>> Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> >>> [Emil Velikov: remove unused variables, Eric] >>> Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> >> >> I think that's pretty much exactly the patch I have at home :) >> (and that I forgot to send out last night) >> >> Reviewed-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx> >> > Thanks pushed to master. Sorry again for the slow response here, but an after-the-fact thanks for sending out the much improved version! I really appreciate it! -john _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel