On Tue, 20 Mar 2018, Haneen Mohammed wrote:
> This patch remove the compatibility aliases
> drm_property_{reference/unreference}_blob of
> drm_property_blob_{get/put} since all callers have been converted to the
> prefered _{get/put}.
>
> Remove the helpers from the semantic patch drm-get-put-cocci.
>
> Signed-off-by: Haneen Mohammed <hamohammed.sa@xxxxxxxxx>
Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
For the Coccinelle part.
> ---
> include/drm/drm_property.h | 26 --------------------------
> scripts/coccinelle/api/drm-get-put.cocci | 10 ----------
> 2 files changed, 36 deletions(-)
>
> diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h
> index 8a522b4..08d5dbb 100644
> --- a/include/drm/drm_property.h
> +++ b/include/drm/drm_property.h
> @@ -279,32 +279,6 @@ struct drm_property_blob *drm_property_blob_get(struct drm_property_blob *blob);
> void drm_property_blob_put(struct drm_property_blob *blob);
>
> /**
> - * drm_property_reference_blob - acquire a blob property reference
> - * @blob: DRM blob property
> - *
> - * This is a compatibility alias for drm_property_blob_get() and should not be
> - * used by new code.
> - */
> -static inline struct drm_property_blob *
> -drm_property_reference_blob(struct drm_property_blob *blob)
> -{
> - return drm_property_blob_get(blob);
> -}
> -
> -/**
> - * drm_property_unreference_blob - release a blob property reference
> - * @blob: DRM blob property
> - *
> - * This is a compatibility alias for drm_property_blob_put() and should not be
> - * used by new code.
> - */
> -static inline void
> -drm_property_unreference_blob(struct drm_property_blob *blob)
> -{
> - drm_property_blob_put(blob);
> -}
> -
> -/**
> * drm_property_find - find property object
> * @dev: DRM device
> * @file_priv: drm file to check for lease against.
> diff --git a/scripts/coccinelle/api/drm-get-put.cocci b/scripts/coccinelle/api/drm-get-put.cocci
> index ceb71ea..3a09c97 100644
> --- a/scripts/coccinelle/api/drm-get-put.cocci
> +++ b/scripts/coccinelle/api/drm-get-put.cocci
> @@ -40,12 +40,6 @@ expression object;
> - drm_gem_object_unreference_unlocked(object)
> + drm_gem_object_put_unlocked(object)
> |
> -- drm_property_reference_blob(object)
> -+ drm_property_blob_get(object)
> -|
> -- drm_property_unreference_blob(object)
> -+ drm_property_blob_put(object)
> -|
> - drm_dev_unref(object)
> + drm_dev_put(object)
> )
> @@ -72,10 +66,6 @@ __drm_gem_object_unreference(object)
> |
> drm_gem_object_unreference_unlocked(object)
> |
> -drm_property_unreference_blob@p(object)
> -|
> -drm_property_reference_blob@p(object)
> -|
> drm_dev_unref@p(object)
> )
>
> --
> 2.7.4
>
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
