On 19 March 2018 at 13:47, John Stultz <john.stultz@xxxxxxxxxx> wrote: > Building libdrm under AOSP, we see the following build warning: > external/libdrm/xf86drm.c:2861:12: warning: 'readdir_r' is deprecated: readdir_r is deprecated; use readdir instead [-Wdeprecated-declarations] > while (readdir_r(sysdir, pent, &ent) == 0 && ent != NULL) { > ^ > > Thus, this patch replaces readdir_r with readdir. > When C runtime suggests new behaviour before the manual/spec is updated... sigh. readdir(3) It is expected that a future version of POSIX.1 will require that readdir() be thread-safe when concurrently employed on different directory streams readdir_r(3) It is expected that a future version of POSIX.1 will make readdir_r() obsolete, and require that readdir(3) be thread-safe when concurrently employed on different directory streams. Regardless, patch is Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel