Re: [PATCH libdrm 3/4] meson,configure: always define UDEV

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16 March 2018 at 17:12, Eric Engestrom <eric.engestrom@xxxxxxxxxx> wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx>
> ---
>  configure.ac | 2 ++
>  meson.build  | 2 +-
>  xf86drm.c    | 8 ++++----
>  3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 14baa1c87f9078f336fa..619af49726d198c5d685 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -347,6 +347,8 @@ AC_SUBST(PCIACCESS_LIBS)
>
>  if test "x$UDEV" = xyes; then
>         AC_DEFINE(UDEV, 1, [Have UDEV support])
> +else
> +       AC_DEFINE(UDEV, 0)
>  fi
>
>  AC_CANONICAL_HOST
> diff --git a/meson.build b/meson.build
> index 8d4d38b46ebcf75b9fb6..0fe04a1411963c70cf80 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -165,9 +165,9 @@ if _libkms != 'false'
>    with_libkms = _libkms == 'true' or ['linux', 'freebsd', 'dragonfly'].contains(host_machine.system())
>  endif
>
> +config.set10('UDEV', with_udev)
This looks fine.


>  if with_udev
>    dep_udev = dependency('udev')
> -  config.set10('UDEV', true)
>  else
>    dep_udev = []
>  endif
Does this pull udev.pc or libudev.pc?

In either case the whole thing can go - see
0ec7252a1deba3bac78b5ba1ebd2898f6bbf0332 + parent commit.

The series is
Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux