On 14.03.2018 16:25, Fabio Estevam wrote:
> Hi Laurent,
>
> On Mon, Feb 19, 2018 at 4:50 PM, Laurent Pinchart
> <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>> Hi Fabio,
>>
>> Thank you for the patch.
>>
>> On Friday, 16 February 2018 22:16:10 EET Fabio Estevam wrote:
>>> From: Fabio Estevam <fabio.estevam@xxxxxxx>
>>>
>>> The cable_plugin member never receives an assignment, so it is always
>>> false, which causes hdmi_enable_overflow_interrupts() to never
>>> be called as per the logic below:
>>>
>>> if (hdmi->cable_plugin && hdmi->sink_is_hdmi)
>>> hdmi_enable_overflow_interrupts(hdmi);
>>>
>>> This has been the case since the driver was originally introduced
>>> in commit 9aaf880ed4ee ("imx-drm: Add mx6 hdmi transmitter support").
>>>
>>> Remove the cable_plugin element and the hdmi_enable_overflow_interrupts()
>>> function that is never called.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
>> Tested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> # On R-Car H3
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Are you able to apply this patch or should Archit Taneja handle it?
Queued to drm-misc-next.
Regards
Andrzej
>
> Thanks
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
