Hi folks,
this is a follow up patch set to my initial tree wide refactoring
Subject: Introduce DRM_FB_HELPER_DEFAULT_OPS for struct fb_ops
https://patchwork.freedesktop.org/series/13099/
nearly one and a half year ago. It contains three patches for drivers
ast, hisilicon and mgag200
that are currently not using DRM_FB_HELPER_DEFAULT_OPS.
If the conversion is appropriate for your driver, you can pick up the
patch. If not (because it may enable untested functionality), you can
just ignore it. It's only a gentle remainder in case the conversion was
missed in the first version/round.
In detail: One and a half year ago the drivers 'ast' and 'mgag200' did
not use much of the drm_fb_helper functions. Now they do, so using
DRM_FB_HELPER_DEFAULT_OPS seems beneficial.
The drm driver 'hisilicon' was either missed in the initial patch set or
the driver was just added later.
Except the three drivers above, there are only two drivers not using
DRM_FB_HELPER_DEFAULT_OPS left in the whole tree (v4.16-rc1): 'cirrus'
and 'vmwgfx'. The former is marked as *do-not-touch* by checkpatch.pl
and the later implements all fb_ops functions on it's on. No need for a
conversion.
Last but not least: The driver 'omapdrm' just received a patch for the
next kernel version to drop DRM_FB_HELPER_DEFAULT_OPS again. It causes a
compiler waring 'Initializer entry defined twice', because the driver
reassigns .fb_pan_display which is already provided in
DRM_FB_HELPER_DEFAULT_OPS.
Kind Regards,
Stefan
Cc: Dave Airlie <airlied@xxxxxxxxxx>
Cc: Rongrong Zou <zourongrong@xxxxxxxxx>
Cc: Xinliang Liu <z.liuxinliang@xxxxxxxxxxxxx>
---
Stefan Lengfeld (3):
drm/ast: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops
drm/hisilicon: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops
drm/mgag200: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops
drivers/gpu/drm/ast/ast_fb.c | 8 +-------
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 6 +-----
drivers/gpu/drm/mgag200/mgag200_fb.c | 6 +-----
3 files changed, 3 insertions(+), 17 deletions(-)
--
2.16.1
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
