Hi Maruthi,
FYI, the error/warning still remains.
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head: 701dfa780797b7124ba47026a2f071d3f1c6fb2b
commit: 944b5289c92d9c1aad3760c012daf4cf2478381f [699/881] ASoC: AMD: enable ACP3x drivers build
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 944b5289c92d9c1aad3760c012daf4cf2478381f
# save the attached .config to linux build tree
make.cross ARCH=sh
All errors (new ones prefixed by >>):
sound/soc/amd/raven/pci-acp3x.c: In function 'snd_acp3x_probe':
>> sound/soc/amd/raven/pci-acp3x.c:58:8: error: implicit declaration of function 'pci_enable_msi'; did you mean 'pci_enable_sriov'? [-Werror=implicit-function-declaration]
ret = pci_enable_msi(pci);
^~~~~~~~~~~~~~
pci_enable_sriov
>> sound/soc/amd/raven/pci-acp3x.c:122:2: error: implicit declaration of function 'pci_disable_msi'; did you mean 'pci_disable_sriov'? [-Werror=implicit-function-declaration]
pci_disable_msi(pci);
^~~~~~~~~~~~~~~
pci_disable_sriov
sound/soc/amd/raven/pci-acp3x.c: At top level:
sound/soc/amd/raven/pci-acp3x.c:159:1: warning: data definition has no type or storage class
module_pci_driver(acp3x_driver);
^~~~~~~~~~~~~~~~~
>> sound/soc/amd/raven/pci-acp3x.c:159:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int]
sound/soc/amd/raven/pci-acp3x.c:159:1: warning: parameter names (without types) in function declaration
sound/soc/amd/raven/pci-acp3x.c:152:26: warning: 'acp3x_driver' defined but not used [-Wunused-variable]
static struct pci_driver acp3x_driver = {
^~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +58 sound/soc/amd/raven/pci-acp3x.c
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 29
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 30 static int snd_acp3x_probe(struct pci_dev *pci,
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 31 const struct pci_device_id *pci_id)
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 32 {
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 33 int ret;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 34 u32 addr, val;
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 35 struct acp3x_dev_data *adata;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 36 struct platform_device_info pdevinfo;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 37 unsigned int irqflags;
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 38
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 39 if (pci_enable_device(pci)) {
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 40 dev_err(&pci->dev, "pci_enable_device failed\n");
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 41 return -ENODEV;
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 42 }
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 43
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 44 ret = pci_request_regions(pci, "AMD ACP3x audio");
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 45 if (ret < 0) {
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 46 dev_err(&pci->dev, "pci_request_regions failed\n");
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 47 goto disable_pci;
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 48 }
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 49
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 50 adata = devm_kzalloc(&pci->dev, sizeof(struct acp3x_dev_data),
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 51 GFP_KERNEL);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 52 if (adata == NULL) {
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 53 ret = -ENOMEM;
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 54 goto release_regions;
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 55 }
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 56
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 57 /* check for msi interrupt support */
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 @58 ret = pci_enable_msi(pci);
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 59 if (ret)
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 60 /* msi is not enabled */
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 61 irqflags = IRQF_SHARED;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 62 else
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 63 /* msi is enabled */
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 64 irqflags = 0;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 65
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 66 addr = pci_resource_start(pci, 0);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 67 adata->acp3x_base = ioremap(addr, pci_resource_len(pci, 0));
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 68 if (adata->acp3x_base == NULL) {
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 69 ret = -ENOMEM;
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 70 goto release_regions;
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 71 }
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 72
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 73 pci_set_drvdata(pci, adata);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 74
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 75 val = rv_readl(adata->acp3x_base + mmACP_I2S_PIN_CONFIG);
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 76 if (val == 0x4) {
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 77 adata->res = devm_kzalloc(&pci->dev,
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 78 sizeof(struct resource) * 2,
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 79 GFP_KERNEL);
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 80 if (adata->res == NULL) {
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 81 ret = -ENOMEM;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 82 goto unmap_mmio;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 83 }
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 84
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 85 adata->res[0].name = "acp3x_i2s_iomem";
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 86 adata->res[0].flags = IORESOURCE_MEM;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 87 adata->res[0].start = addr;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 88 adata->res[0].end = addr + (ACP3x_REG_END - ACP3x_REG_START);
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 89
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 90 adata->res[1].name = "acp3x_i2s_irq";
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 91 adata->res[1].flags = IORESOURCE_IRQ;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 92 adata->res[1].start = pci->irq;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 93 adata->res[1].end = pci->irq;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 94
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 95 adata->acp3x_audio_mode = ACP3x_I2S_MODE;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 96
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 97 memset(&pdevinfo, 0, sizeof(pdevinfo));
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 98 pdevinfo.name = "acp3x_rv_i2s";
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 99 pdevinfo.id = 0;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 100 pdevinfo.parent = &pci->dev;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 101 pdevinfo.num_res = 2;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 102 pdevinfo.res = adata->res;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 103 pdevinfo.data = &irqflags;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 104 pdevinfo.size_data = sizeof(irqflags);
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 105
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 106 adata->pdev = platform_device_register_full(&pdevinfo);
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 107 if (adata->pdev == NULL) {
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 108 dev_err(&pci->dev, "cannot register %s device\n",
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 109 pdevinfo.name);
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 110 ret = -ENODEV;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 111 goto unmap_mmio;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 112 }
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 113 } else {
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 114 dev_err(&pci->dev, "Inavlid ACP audio mode : %d\n", val);
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 115 ret = -ENODEV;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 116 goto unmap_mmio;
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 117 }
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 118
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 119 return 0;
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 120
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 121 unmap_mmio:
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 @122 pci_disable_msi(pci);
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 123 iounmap(adata->acp3x_base);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 124 release_regions:
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 125 pci_release_regions(pci);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 126 disable_pci:
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 127 pci_disable_device(pci);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 128
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 129 return ret;
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 130 }
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 131
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 132 static void snd_acp3x_remove(struct pci_dev *pci)
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 133 {
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 134 struct acp3x_dev_data *adata = pci_get_drvdata(pci);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 135
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 136 platform_device_unregister(adata->pdev);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 137 iounmap(adata->acp3x_base);
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 138
4a00d378 Maruthi Srinivas Bayyavarapu 2017-03-29 139 pci_disable_msi(pci);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 140 pci_release_regions(pci);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 141 pci_disable_device(pci);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 142 }
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 143
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 144 static const struct pci_device_id snd_acp3x_ids[] = {
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 145 { PCI_DEVICE(PCI_VENDOR_ID_AMD, 0x15e2),
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 146 .class = PCI_CLASS_MULTIMEDIA_OTHER << 8,
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 147 .class_mask = 0xffffff },
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 148 { 0, },
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 149 };
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 150 MODULE_DEVICE_TABLE(pci, snd_acp3x_ids);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 151
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 152 static struct pci_driver acp3x_driver = {
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 153 .name = KBUILD_MODNAME,
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 154 .id_table = snd_acp3x_ids,
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 155 .probe = snd_acp3x_probe,
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 156 .remove = snd_acp3x_remove,
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 157 };
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 158
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 @159 module_pci_driver(acp3x_driver);
e8f3716a Maruthi Srinivas Bayyavarapu 2017-03-27 160
:::::: The code at line 58 was first introduced by commit
:::::: 4a00d378ecc1509e8cf401226995f579b7957496 ASoC: AMD: create ACP3x PCM platform device
:::::: TO: Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@xxxxxxx>
:::::: CC: Alex Deucher <alexander.deucher@xxxxxxx>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
