[radeon-alex:drm-next-4.17 458/491] drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:3617:13: error: implicit declaration of function 'amdgpu_acpi_pcie_performance_request'; did you mean 'smu7_pcie_performance_request'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rex,

FYI, the error/warning still remains.

tree:   git://people.freedesktop.org/~agd5f/linux.git drm-next-4.17
head:   f6c3b601bd490eda08c27b03607448abd4b4841b
commit: e1deba285156fb4023bb48f22068de5b60e34e15 [458/491] drm/amd/pp: Use amdgpu acpi helper functions in powerplay
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout e1deba285156fb4023bb48f22068de5b60e34e15
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c: In function 'smu7_request_link_speed_change_before_state_change':
>> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:3617:13: error: implicit declaration of function 'amdgpu_acpi_pcie_performance_request'; did you mean 'smu7_pcie_performance_request'? [-Werror=implicit-function-declaration]
       if (0 == amdgpu_acpi_pcie_performance_request(hwmgr->adev, PCIE_PERF_REQ_GEN3, false))
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                smu7_pcie_performance_request
   cc1: some warnings being treated as errors

vim +3617 drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c

  3591	
  3592	static int smu7_request_link_speed_change_before_state_change(
  3593			struct pp_hwmgr *hwmgr, const void *input)
  3594	{
  3595		const struct phm_set_power_state_input *states =
  3596				(const struct phm_set_power_state_input *)input;
  3597		struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
  3598		const struct smu7_power_state *smu7_nps =
  3599				cast_const_phw_smu7_power_state(states->pnew_state);
  3600		const struct smu7_power_state *polaris10_cps =
  3601				cast_const_phw_smu7_power_state(states->pcurrent_state);
  3602	
  3603		uint16_t target_link_speed = smu7_get_maximum_link_speed(hwmgr, smu7_nps);
  3604		uint16_t current_link_speed;
  3605	
  3606		if (data->force_pcie_gen == PP_PCIEGenInvalid)
  3607			current_link_speed = smu7_get_maximum_link_speed(hwmgr, polaris10_cps);
  3608		else
  3609			current_link_speed = data->force_pcie_gen;
  3610	
  3611		data->force_pcie_gen = PP_PCIEGenInvalid;
  3612		data->pspp_notify_required = false;
  3613	
  3614		if (target_link_speed > current_link_speed) {
  3615			switch (target_link_speed) {
  3616			case PP_PCIEGen3:
> 3617				if (0 == amdgpu_acpi_pcie_performance_request(hwmgr->adev, PCIE_PERF_REQ_GEN3, false))
  3618					break;
  3619				data->force_pcie_gen = PP_PCIEGen2;
  3620				if (current_link_speed == PP_PCIEGen2)
  3621					break;
  3622			case PP_PCIEGen2:
  3623				if (0 == amdgpu_acpi_pcie_performance_request(hwmgr->adev, PCIE_PERF_REQ_GEN2, false))
  3624					break;
  3625			default:
  3626				data->force_pcie_gen = smu7_get_current_pcie_speed(hwmgr);
  3627				break;
  3628			}
  3629		} else {
  3630			if (target_link_speed < current_link_speed)
  3631				data->pspp_notify_required = true;
  3632		}
  3633	
  3634		return 0;
  3635	}
  3636	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux