Re: [PATCH 2/2] drm/kms: Use the standard VESA timeout for DDC channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 21 Oct 2011 09:10:12 +0200, Jean Delvare <jdelvare@xxxxxxx> wrote:

> -		/* vesa says 2.2 ms is enough, 1 jiffy doesn't seem to always
> -		 * make this, 2 jiffies is a lot more reliable */
> -		i2c->algo.bit.timeout = 2;
> +		i2c->algo.bit.timeout = usecs_to_jiffies(2200);	/* from VESA */

From my reading of the usecs_to_jiffies code, it always returns a time
at least as long as requested, so this will ensure that you're waiting
at least 2.2ms, unlike 2 jiffies which is some random amount of time
depending on the HZ setting in the kernel.

Reviewed-by: Keith Packard <keithp@xxxxxxxxxx>

-- 
keith.packard@xxxxxxxxx

Attachment: pgpcpAyZYEE5_.pgp
Description: PGP signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux