[radeon-alex:amd-staging-drm-next 699/741] sound/soc/amd/raven/acp3x-pcm-dma.c:246:10: error: implicit declaration of function 'page_to_phys'; did you mean 'page_to_pfn'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Maruthi,

FYI, the error/warning still remains.

tree:   git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head:   63e5921e856bcab4a89610f3ec7c8e139fd96408
commit: 944b5289c92d9c1aad3760c012daf4cf2478381f [699/741] ASoC: AMD: enable ACP3x drivers build
config: tile-allyesconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 944b5289c92d9c1aad3760c012daf4cf2478381f
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All errors (new ones prefixed by >>):

   In file included from sound/soc/amd/raven/acp3x-pcm-dma.c:26:0:
   sound/soc/amd/raven/acp3x.h: In function 'rv_readl':
   sound/soc/amd/raven/acp3x.h:28:9: error: implicit declaration of function 'readl'; did you mean 'vread'? [-Werror=implicit-function-declaration]
     return readl(base_addr - ACP3x_PHY_BASE_ADDRESS);
            ^~~~~
            vread
   sound/soc/amd/raven/acp3x.h: In function 'rv_writel':
   sound/soc/amd/raven/acp3x.h:33:2: error: implicit declaration of function 'writel'; did you mean 'vwrite'? [-Werror=implicit-function-declaration]
     writel(val, base_addr - ACP3x_PHY_BASE_ADDRESS);
     ^~~~~~
     vwrite
   sound/soc/amd/raven/acp3x-pcm-dma.c: In function 'config_acp3x_dma':
>> sound/soc/amd/raven/acp3x-pcm-dma.c:246:10: error: implicit declaration of function 'page_to_phys'; did you mean 'page_to_pfn'? [-Werror=implicit-function-declaration]
      addr = page_to_phys(pg);
             ^~~~~~~~~~~~
             page_to_pfn
   sound/soc/amd/raven/acp3x-pcm-dma.c: In function 'acp3x_audio_probe':
   sound/soc/amd/raven/acp3x-pcm-dma.c:638:22: error: implicit declaration of function 'devm_ioremap'; did you mean 'devm_kmemdup'? [-Werror=implicit-function-declaration]
     adata->acp3x_base = devm_ioremap(&pdev->dev, res->start,
                         ^~~~~~~~~~~~
                         devm_kmemdup
   sound/soc/amd/raven/acp3x-pcm-dma.c:638:20: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     adata->acp3x_base = devm_ioremap(&pdev->dev, res->start,
                       ^
   cc1: some warnings being treated as errors

vim +246 sound/soc/amd/raven/acp3x-pcm-dma.c

68f9fb0c Maruthi Srinivas Bayyavarapu 2017-03-30  222  
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  223  static void config_acp3x_dma(struct i2s_stream_instance *rtd, int direction)
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  224  {
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  225  	u16 page_idx;
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  226  	u64 addr;
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  227  	u32 low, high, val, acp_fifo_addr;
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  228  	struct page *pg = rtd->pg;
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  229  
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  230  	/* 8 scratch registers used to map one 64 bit address.
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  231  	 * For 2 pages (4096 * 2 bytes), it will be 16 registers.
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  232  	 */
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  233  	if (direction == SNDRV_PCM_STREAM_PLAYBACK)
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  234  		val = 0;
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  235  	else
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  236  		val = 16;
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  237  
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  238  	/* Group Enable */
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  239  	rv_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp3x_base +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  240  					mmACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  241  	rv_writel(PAGE_SIZE_4K_ENABLE, rtd->acp3x_base +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  242  			mmACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  243  
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  244  	for (page_idx = 0; page_idx < rtd->num_pages; page_idx++) {
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  245  		/* Load the low address of page int ACP SRAM through SRBM */
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29 @246  		addr = page_to_phys(pg);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  247  		low = lower_32_bits(addr);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  248  		high = upper_32_bits(addr);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  249  
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  250  		rv_writel(low, rtd->acp3x_base + mmACP_SCRATCH_REG_0 + val);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  251  		high |= BIT(31);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  252  		rv_writel(high, rtd->acp3x_base + mmACP_SCRATCH_REG_0 + val
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  253  				+ 4);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  254  		/* Move to next physically contiguos page */
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  255  		val += 8;
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  256  		pg++;
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  257  	}
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  258  
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  259  	if (direction == SNDRV_PCM_STREAM_PLAYBACK) {
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  260  		/* Config ringbuffer */
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  261  		rv_writel(MEM_WINDOW_START, rtd->acp3x_base +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  262  				mmACP_BT_TX_RINGBUFADDR);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  263  		rv_writel(MAX_BUFFER, rtd->acp3x_base +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  264  				mmACP_BT_TX_RINGBUFSIZE);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  265  		rv_writel(0x40, rtd->acp3x_base + mmACP_BT_TX_DMA_SIZE);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  266  
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  267  		/* Config audio fifo */
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  268  		acp_fifo_addr = ACP_SRAM_PTE_OFFSET + (rtd->num_pages * 8)
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  269  				+ 1024;
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  270  		rv_writel(acp_fifo_addr, rtd->acp3x_base +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  271  				mmACP_BT_TX_FIFOADDR);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  272  		rv_writel(256, rtd->acp3x_base + mmACP_BT_TX_FIFOSIZE);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  273  		rv_writel(PLAYBACK_MIN_PERIOD_SIZE, rtd->acp3x_base +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  274  				mmACP_BT_TX_INTR_WATERMARK_SIZE);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  275  	} else {
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  276  		/* Config ringbuffer */
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  277  		rv_writel(MEM_WINDOW_START + MAX_BUFFER, rtd->acp3x_base +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  278  				mmACP_BT_RX_RINGBUFADDR);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  279  		rv_writel(MAX_BUFFER, rtd->acp3x_base +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  280  				mmACP_BT_RX_RINGBUFSIZE);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  281  		rv_writel(0x40, rtd->acp3x_base + mmACP_BT_RX_DMA_SIZE);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  282  
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  283  		/* Config audio fifo */
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  284  		acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  285  				(rtd->num_pages * 8) + 1024 + 256;
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  286  		rv_writel(acp_fifo_addr, rtd->acp3x_base +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  287  				mmACP_BT_RX_FIFOADDR);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  288  		rv_writel(256, rtd->acp3x_base + mmACP_BT_RX_FIFOSIZE);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  289  		rv_writel(CAPTURE_MIN_PERIOD_SIZE, rtd->acp3x_base +
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  290  				mmACP_BT_RX_INTR_WATERMARK_SIZE);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  291  	}
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  292  
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  293  	/* Enable  watermark/period interrupt to host */
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  294  	rv_writel(BIT(BT_TX_THRESHOLD) | BIT(BT_RX_THRESHOLD),
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  295  			rtd->acp3x_base + mmACP_EXTERNAL_INTR_CNTL);
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  296  }
afdf7669 Maruthi Srinivas Bayyavarapu 2017-03-29  297  

:::::: The code at line 246 was first introduced by commit
:::::: afdf7669c25e9b8f4458a86650ba133890bbd647 ASoC: AMD: add ACP3x PCM driver DMA ops

:::::: TO: Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@xxxxxxx>
:::::: CC: Alex Deucher <alexander.deucher@xxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux